divyankshah commented on issue #4084: URL: https://github.com/apache/jena/issues/4084#issuecomment-5062561211
Hi @afs , I'd like to pick this up. Here is my Approach - 1) I'll fix it in JettyServer.jettyServer(minThreads, maxThreads), the shared factory both JettyHttps.java and FusekiServer.java already call to build their base Server. Fixing it there means neither caller needs any changes. 2) I'll construct an ArrayByteBufferPool sized to FusekiSystemConstants.jettyOutputBufferSize (currently 5MB) and pass it into Server(ThreadPool, Scheduler, ByteBufferPool) at construction time. 3) scheduler will be passed as null. I checked this reproduces the exact default ScheduledExecutorScheduler that Server(ThreadPool) already creates internally, confirmed by decompiling the constructor and comparing the bytecode. One thing worth flagging in case anyone else runs into it: server.addBean(pool) after construction doesn't actually work. new Server(threadPool) already wires in its own default 64KB ArrayByteBufferPool at construction time, so a bean added afterward just sits there registered but unused. The 3-arg constructor is needed to actually replace it. Will follow up with a PR shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
