https://issues.apache.org/bugzilla/show_bug.cgi?id=54230
--- Comment #13 from Sebb <[email protected]> --- (In reply to comment #12) > (In reply to comment #11) > > The existing TCP Config and Sampler GUIs differ only in that the login > > section is only present on the sampler. > > > > However, your screen shot shows the additional Close Connection box on the > > Sampler. The TCP config screen shot shows SO_LINGER and EOL only - the Reuse > > connection and Set NoDelay check-boxes are missing, and there is no Close > > Connection. > > > > This seems wrong. Existing test plans that use the config element > > check-boxes will no longer work. > > > > Generally, the config screen is the same as the sampler screen, except for > > any fields that just don't make sense for a sampler. I'm not sure that > > applies to any of the new settings. For example if Re-use connection is not > > selected, then all the settings would apply to a TCP sampler. > > But the problem is the checkbox, if a checkbox option is placed on both of > sampler and config, the value of the checkbox on the config is useless. So > in case of checkbox option, those should be placed only on one of them. So I > arranged like that. Regardless, this Bugzilla is an enhancement request, so should not change the existing behaviour unnecessarily. Also, the text fields should appear on both screens. > And furthermore, Philippe Mouawad suggested replacing checkbox by selectbox > like several options on HTTP Sampler. And I agreed with that. I will use > select boxes and place them on both of TCP Sampler and TCP Sampler Config on > my next patch. That is one possible option. It would be nicer to implement 3-state checkboxes, as that would not require extra screen-space. The indeterminate state would mean to use the default. So it's not appropriate to fix this as part of this enhancement. > So how do you think I would rearrange those options for now? The new fields should be added to the existing GUI, to both config and sampler. However, the Close Connection makes slightly less sense for the config screen, so could perhaps be omitted from that. -- You are receiving this mail because: You are the assignee for the bug.
