https://issues.apache.org/bugzilla/show_bug.cgi?id=54777

--- Comment #2 from Sebb <[email protected]> ---
Thanks for the suggested patch. I'm not clear why the code should be better
than PrintWriter.println() - this ought to be explained in the Javadoc.

There are some problems with the code as it stands:

The field lineSeparator cannot be fixed as '\n', as that is not portable.

Constructors should not start threads - there is no guarantee that the class
will have been fully constructed before the thread tries accessing it.

A couple of minor style issues: we don't generally allow multiple statements
per line.
Aslo we always use blocks in conditional statements.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to