https://issues.apache.org/bugzilla/show_bug.cgi?id=55064
Bug ID: 55064
Summary: wasted work in ReportTreeListener.isValidDragAction()
Product: JMeter
Version: 2.9
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Main
Assignee: [email protected]
Reporter: [email protected]
Created attachment 30399
--> https://issues.apache.org/bugzilla/attachment.cgi?id=30399&action=edit
patch
The problem appears in version 2.9 and in revision 1489981. I
attached a one-line patch that fixes it. This problem and the patch
are similar to the previously fixed Bug 55056.
In method "ReportTreeListener.isValidDragAction", the loop over "path"
should break immediately after "isValid" is set to "false". All the
iterations after "isValid" is set to "false" do not perform any useful
work, at best they just set "isValid" again to "false".
Method "include" in class "ClassFilter" has a similar loop (over
"pkgs"), and this loop breaks immediately after "inc" is set to
"true", just like in the proposed patch. Other methods (e.g.,
"Copy.keepOnlyAncestors", "JMeterThread.getSampleListeners",
"HTTPSamplerBase.getSendParameterValuesAsPostBody",
"LogFilter.incFile") also have similar loops with similar breaks, just
like in the proposed patch.
--
You are receiving this mail because:
You are the assignee for the bug.
