https://issues.apache.org/bugzilla/show_bug.cgi?id=53480
--- Comment #8 from Philippe Mouawad <[email protected]> --- Hello, Thanks for patch. Few notes about it: - could you provide it in unified format,"If you are providing a patch to fix a bug, please ensure it is in unified diff format. If using Eclipse, please set the patch root to "Project", not the default "Workspace" which is harder to apply." - looking at implementation, I see the following issues or enhancements : 1) kerberos is a boolean, I think it would be better to have a select box if we want to have another type of auth like Digest 2) Code seems to me intrusive regarding Kerberos in HTTPHC4Impl. This is probably due to Subject.doAs. Maybe we should enhance AuthManager with a method like isSubjectBased(url). If it returns true , we would call authManager.getSubject(authorization) and call Subject.doAs, if not we just call httpClient.execute. This way it would not be directly related to Kerberos. Same for setConnectionAuthorization, maybe we should call authManager.handle(auth), which would make code cleaner. -- You are receiving this mail because: You are the assignee for the bug.
