https://issues.apache.org/bugzilla/show_bug.cgi?id=55375
--- Comment #7 from Philippe Mouawad <[email protected]> --- (In reply to Sebb from comment #6) > The patch effectively converts the stack overflow into an illegal state > exception. > The benefit is that the message reports the name offending test element > (though this may not be unique). Shall I commit it ? > > However it does not solve the issue that the non-GUI code behaves > differently from the GUI code. In fact both GUI and Non GUI behave identically except that sometimes GUI picks the first element instead of picking the second one. But if you fix it then you get a StackOverflow. > > Ideally any fix should address the different behaviour and prevent recursive > calls. Fix prevents recursive calls. > > If the MC refused to allow multiple controllers with the same name, that > should solve the behaviour difference, but it could affect some test plans. > Given that at present the non-GUI code does not have sufficient information > to choose the correct controller in the case of duplicates, that change is > probably acceptable. Not sure > > The other issue is that the user may choose a target which is a parent of > the MC, causing stack overflow. If controller names must be unique then this > should be less likely to occur. Since such targets are useless, ideally they > should be excluded from the list. This would need to be done after duplicate > checking. Could be next step. -- You are receiving this mail because: You are the assignee for the bug.
