https://issues.apache.org/bugzilla/show_bug.cgi?id=52061
--- Comment #5 from Dzmitry Kashlach <[email protected]> --- (In reply to Sebb from comment #4) > One problem I did notice amongst the noise is that it renames a public > constant [1] (and changes the value). That will break existing test plans. > [1] public static final String USE_HDRS = "true"; // $NON-NLS-1$ Hi Sebb, Sorry for not answering for so long. Yes, I agree about comment regarding reformatting: this was just default settings of IDE. Attached cleaned patch. Can you help with a question about "public static final String USE_HDRS = "true";? If we have two radio-buttons for headers(Resp. Headers and Req. Headers), we need to differ them somehow from each other and other radio-buttons. I see, that other variables have not only "true/false" value, but strings. public static final String USE_BODY_UNESCAPED = "unescaped"; // $NON-NLS-1$ public static final String USE_BODY_AS_DOCUMENT = "as_document"; // $NON-NLS-1$ So, I'd suggest to change name/values of variables to: public static final String USE_RESPONSE_HDRS = "response_headers"; // $NON-NLS-1$ public static final String USE_REQUEST_HDRS = "request_headers"; // $NON-NLS-1$ You're right, that changing this variable involves changing unit-tests. The only test-suite, where this variable is used is TestRegexExtractor in public void testVariableExtraction7()(line 229). Can I also adjust test-suite according to changes? -- You are receiving this mail because: You are the assignee for the bug.
