https://issues.apache.org/bugzilla/show_bug.cgi?id=42248

Andrey Pohilko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31901|0                           |1
        is obsolete|                            |

--- Comment #31 from Andrey Pohilko <[email protected]> ---
Created attachment 31906
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31906&action=edit
proposed patch with more changes

Philippe, thanks for reviewing the patch. I made some changes:
- removed wildcard import
- added some comments and JavaDocs
- added undo.size property to manipulate history length, default is 25

The undo for TestElement property change already works. History is recorded
once changes applied to TestPlan.

I think disabling the undo is unnecessary, since it is vital feature for JMeter
users. The option to limit history size helps protecting from too much memory
consumption. 

The choice seems to be to provide people undo without in-fields undo, or not
provide ability to revert the actions at all. I believe the value for this
feature is too high to block it for more years waiting to implement in-fields
undo...

Hope this makes sense.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to