https://issues.apache.org/bugzilla/show_bug.cgi?id=25430
Philippe Mouawad <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEEDINFO --- Comment #4 from Philippe Mouawad <[email protected]> --- Hello Dzimitry, First thank you for your contribution. Few notes on patch: - There are no javadocs for many methods, can you add meaningful docs that explains them and comments for some processing - AFAIU You code makes hypothesis that Authorization is Basic while it can be Digest. So you need to adapt code to handle this case, it would make it even smarter :-) - getAuthorization should be named differently as it in fact removes from Headers the one named HTTPConstants.HEADER_AUTHORIZATION) once it has handled the creation of Auth Manager. - Proxy#run : add some docs to explain that HEADER_AUTHORIZATION is removed - In AuthManager#addAuth , can you explain what removeMatchingAuthorizations exactly does Thanks -- You are receiving this mail because: You are the assignee for the bug.
