https://bz.apache.org/bugzilla/show_bug.cgi?id=57913
--- Comment #1 from Felix Schumacher <[email protected]> --- I think the general idea is great. Nobody likes it, when their work vanishes while saving. Even when it saves correctly, one might have done something stupid and would like to have it back. I wonder, if it would be nicer to enumerate the backup files and keep the .jmx suffix. The time and date of the save operation, will most probably be available by looking at the file stats. And I don't know if I like the idea of a directory called after the file name. Apart from that, a few nitpicks: * instead of backup_when_saving I would have chosen backup_on_save or backup_before_save * One comment is "... everything when right..." where it probably should be "... everything went right ..." * deleteMe variable could be renamed to expiredBackupFile or something alike * in javadoc shorten the code tag in line 249ff to enclose only code fragments, that way true and false could be tagged as code as well * The variable emptyList in line 265 could probably be inlined in line 270 * line 297 "expiry date" or your "cutoff date" instead of "oldest date"? -- You are receiving this mail because: You are the assignee for the bug.
