https://bz.apache.org/bugzilla/show_bug.cgi?id=57981
--- Comment #19 from Felix Schumacher <[email protected]> --- Applied most of part 2 and part 3. Did not apply the usage of Arrays.asList to simplify filling of a linked list and conversion of tests using indexOf to contains. For first one I believe it would take more memory, since the list would have to be constructed instead of simple using the already existing array. For the second one I don't see the need. Again thanks for the patch (while you really should try to separate space-changes and logic modifications). Date: Sun Aug 30 13:12:16 2015 New Revision: 1700116 URL: http://svn.apache.org/r1700116 Log: Convert to for-loop. Based on Patch part 2 from Graham Russell. It contains one renaming of a local variable from laf to a menuItem and a bit of white space policeing. Bugzilla Id: 57981 Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/FileListPanel.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/JLabeledRadioI18N.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterToolBar.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java jmeter/trunk/src/jorphan/org/apache/jorphan/gui/JLabeledChoice.java jmeter/trunk/src/jorphan/org/apache/jorphan/gui/JLabeledTextArea.java jmeter/trunk/src/jorphan/org/apache/jorphan/gui/JLabeledTextField.java jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/ClassFinder.java jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/Functor.java jmeter/trunk/src/jorphan/org/apache/jorphan/util/JOrphanUtils.java Date: Sun Aug 30 13:13:39 2015 New Revision: 1700117 URL: http://svn.apache.org/r1700117 Log: Whitespace police. Part of patch (part 2) from Graham Russell. Bugzilla Id: 57981 Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterMenuBar.java Date: Sun Aug 30 13:14:39 2015 New Revision: 1700118 URL: http://svn.apache.org/r1700118 Log: Use Collections#addAll instead of adding elements by hand. Part of patch (part 2) from Graham Russell. Bugzilla Id: 57981 Modified: jmeter/trunk/src/jorphan/org/apache/jorphan/reflect/ClassFinder.java Date: Sun Aug 30 13:27:25 2015 New Revision: 1700120 URL: http://svn.apache.org/r1700120 Log: Convert to for-loops. Patch based on part 3 from Graham Russell. Contains a few whitespace changes. Bugzilla Id: 57981 Modified: jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/control/gui/JUnitTestSamplerGui.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/config/MultipartUrlConfig.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Proxy.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC3Impl.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/StandardGenerator.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java jmeter/trunk/src/protocol/ldap/org/apache/jmeter/protocol/ldap/sampler/LDAPExtSampler.java jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java jmeter/trunk/test/src/org/apache/jmeter/protocol/http/parser/TestHTMLParser.java jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/accesslog/TestLogFilter.java jmeter/trunk/test/src/org/apache/jorphan/test/AllTests.java Date: Sun Aug 30 13:28:48 2015 New Revision: 1700121 URL: http://svn.apache.org/r1700121 Log: Whitespace changes from part 3 of the patches by Graham Russell. Bugzilla Id: 57981 Modified: jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/control/gui/JUnitTestSamplerGui.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/config/MultipartUrlConfig.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/ProxyControl.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/WSDLHelper.java jmeter/trunk/test/src/org/apache/jmeter/protocol/http/util/accesslog/TestLogFilter.java -- You are receiving this mail because: You are the assignee for the bug.
