https://bz.apache.org/bugzilla/show_bug.cgi?id=59116
Sebb <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #2 from Sebb <[email protected]> --- (In reply to Antonio Gomes Rodrigues from comment #1) > PR 156 commited > https://github.com/apache/jmeter/pull/156.patch Sorry, but the patch is unusable as it stands. There are huge numbers of irrelevant changes which make it all but impossible to review. Here is the summary: .../apache/jmeter/resources/messages.properties | 2689 ++++++++--------- .../apache/jmeter/resources/messages_fr.properties | 2659 ++++++++--------- .../jmeter/protocol/http/proxy/ProxyControl.java | 3039 ++++++++++---------- .../protocol/http/proxy/gui/ProxyControlGui.java | 25 +- 4 files changed, 4223 insertions(+), 4189 deletions(-) I would expect a patch to fix this to be 100 changes or so, not 1000s. Patches should contain the minimum number of changes. This allows developers to quickly review the proposed change. Also once the patch is applied, it makes the history easier to read. If you want the patch to be applied, please provide a minimal one. -- You are receiving this mail because: You are the assignee for the bug.
