https://bz.apache.org/bugzilla/show_bug.cgi?id=59607
--- Comment #2 from [email protected] --- In my understanding of SaveService#readTree, the BIS wrapping was introduced to fall back to the old Avalon format: In case loading the .jmx failed, the BIS was reset to the beginning of the file and the OldSaveService tried loading the file. So the buffer was needed because a FileInputStream normally doesn't support marking. Bug 59064 states that the OldSaveService is now removed from JMeter. Thus, there seems to be no need for the BufferedInputStream wrapping in SaveService#readTree anymore. Why? - XStream's XStream#fromXML(InputStream input) doesn't require an input stream that supports jumping in the file (called 'marking'). - This appears just right: Thinking about the structure of the test plan file format, we never need to jump back in the file: It is simply a dump of a tree without cross-references. -- You are receiving this mail because: You are the assignee for the bug.
