https://bz.apache.org/bugzilla/show_bug.cgi?id=60883
--- Comment #8 from Michael Osipov <[email protected]> --- (In reply to Felix Schumacher from comment #7) > (In reply to Michael Osipov from comment #6) > > (In reply to Felix Schumacher from comment #5) > > > (In reply to Michael Osipov from comment #2) > > > > (In reply to Philippe Mouawad from comment #1) > > > > > Hello Michael, > > > > > Thanks for your proposal. > > > > > Would it be possible to provide a patch or a PR on our github : > > > > > - https://github.com/apache/jmeter > > > > > > > > > > See: > > > > > - http://jmeter.apache.org/building.html > > > > > > > > The patch is the least problem. The problem is this: > > > > > > > > https://github.com/apache/jmeter/blob/trunk/build.xml#L3052-L3065 > > > > > > > > Non-Maven build, it requires direct Internet connection. I have to see > > > > how I > > > > can change this to use either our HTTP proxy or Nexus instance > > > > otherwise I > > > > won't be able to build anything at work. "Setproxy Task" should do it. > > > > You > > > > should consider taking this from tomcat > > > > https://github.com/apache/tomcat85/blob/trunk/build.xml#L2709-L2713 > > > > > > > > ...repo forked...PR pending... > > > > > > Just add your nexus repo url as maven2.repo to build-local.properties. > > > > > > That should be enough to use nexus as the source for the downloads. > > > > Yes, this makes sense, but you still need to pass credentials for the <get> > > task. Can you add this to the build.xml? > > If your nexus is secured by password, than this will probably not work, but > you could have a look at: > > https://bz.apache.org/bugzilla/show_bug.cgi?id=53709 Given that Tomcat does the right thing in its build.xml and it works in our corporate environment, I really do not understand why 53709 was closed as invalid. This is truly an important thing for everything trying to contribute. BTW, this does its job: > diff --git a/build.xml b/build.xml > index 4ddd4513f..d68adb9e6 100644 > --- a/build.xml > +++ b/build.xml > @@ -3054,7 +3054,8 @@ run JMeter unless all the JMeter jars are added. > <echo message="Fetching: ${path}/${jar}" level="info"/> > <get src="${loc}/${jar}" > dest="${build.dir}/${jar}" > - usetimestamp="false" ignoreerrors="false"/> > + usetimestamp="false" ignoreerrors="false" > + username="${nexus.username}" password="${nexus.password}"/> > <antcall target="_checkMD5"> > <param name="file" value="${jar}"/> > <param name="path" value="${build.dir}"/> > -- You are receiving this mail because: You are the assignee for the bug.
