https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #17 from Philippe Mouawad <[email protected]> --- (In reply to Alan Silva from comment #16) > (In reply to Philippe Mouawad from comment #10) > > (In reply to Alan Silva from comment #9) > > > Oh yes. You're absolutely right @Philippe Mouawad. > > > > > > The patch should haven been an if/else. My mistake. > > > > > > In any case, as I said in my previous comment: > > > > > > Calling addSubResult(SampleResult subResult, false) is good enough I > > > think. > > > > > > That's what I ended up doing and I would presume that it's what other > > > Jmeter > > > users that upgraded to 5.0 and use custom result labels did as well. > > > > Hello Alan, > > Thanks for your feedback. > > > > So In your opinion, is it ok to do nothing ? or should we do something. > > > > Of course we should add a note on this in release notes. > > > > Thanks > > Hi, sorry I stopped monitoring this ticket for a bit. > > IMO, you could leave the current implementation as is, as long as it's > mentioned in the rel notes like you suggested. > > As long as other users like myself don't have to open up the code to find > out why things changed, then I think everything is good. > > Cheers Thanks Alan for your feedback. @Artem, thanks a lot for your work on this and PR. But, IMO, we shouldn't do anything about it except add to release notes of 5.0 the Incompatible changes section. -- You are receiving this mail because: You are the assignee for the bug.
