https://bz.apache.org/bugzilla/show_bug.cgi?id=63490

--- Comment #5 from Felix Schumacher <[email protected]> ---
(In reply to Philippe Mouawad from comment #4)
> Hi Felix,
> Can't we find a way to put this code in TimerService and add junit testing ?
> 
> For example, make it return Pair<Boolean, Long> (exit or not/sleep time).

I would probably go for an Optional<Long> and define an empty Optional to mean,
we should end the test, but I am not sure, whether it is a good idea to create
another object instance for this. Same could be expressed by returning a
negative long.

> 
> As you noticed it, it's the 3rd bug around this feature.

The missing test case is one of the reasons, why I haven't committed it yet.

> 
> Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to