https://bz.apache.org/bugzilla/show_bug.cgi?id=64581

            Bug ID: 64581
           Summary: Allow SampleResult#setIgnore to influence behaviour on
                    Sampler Error
           Product: JMeter
           Version: 5.3
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: [email protected]
          Reporter: [email protected]
  Target Milestone: JMETER_5.3.1

Hello,
In version 4.0 of JMeter this method was introduced:

   
https://jmeter.apache.org/api/org/apache/jmeter/samplers/SampleResult.html#setIgnore--


The aim was to provide the ability to custom tester code (JSR Sampler,
PostProcessor) to not emit the SampleResult to listeners.

The current implementation is not be fully ok.

Currently , due to this:
https://github.com/apache/jmeter/blob/master/src/core/src/main/java/org/apache/jmeter/threads/JMeterThread.java#L561

The SampleResult is not considered to decide on what to do:
https://github.com/apache/jmeter/blob/master/src/core/src/main/java/org/apache/jmeter/threads/JMeterThread.java#L586

Besides, currently this condition is useless so it will be fixed:

   
https://github.com/apache/jmeter/blob/master/src/core/src/main/java/org/apache/jmeter/threads/JMeterThread.java#L574


This should be changed as user usually wants to influence whether we switch to
next iteration, stop thread, test.

As a consequence, the enhancement will restrict this method to what its javadoc
states:
- Don't sent 

To avoid breaking existing code relying on it and because it looks correct, if
ignore is set, we will not run:
- Post Processor on it as it is not supposed to concern real request on which
user would like to extract data from response
- Assertion on it as it is not supposed to concern real request on which user
would like to check some content

Considering its use is for impacting algorithmic execution, it will be taken
into account to:

- Decide what to do on Error ("Action to be taken after a Sampler error" in
Thread Group)
- set JMeterThread.last_sample_ok

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to