https://bz.apache.org/bugzilla/show_bug.cgi?id=65217

--- Comment #4 from Mariusz_W <mawa...@gmail.com> ---
Hi I have some thoughts to discuss. 
My suggestions for changes. What do you think?

"value to shift" - this data should be mandatory.  
Currently, it is not mandatory in the documentation, but it is also not given
what the default value is. Due to the task of the function, it seems that it
needs to be specified. 
https://jmeter.apache.org/usermanual/functions.html#__timeShift
test to change: TestTimeShiftFunction.testDefault()
And change in docs.

"Format" 
https://jmeter.apache.org/usermanual/functions.html#__timeShift
If given, it should be correct. Throw exception if DateTimeFormatter can  not
be created.
test to change: TestTimeShiftFunction.testWrongFormatDate()

"value to shift"
https://jmeter.apache.org/usermanual/functions.html#__timeShift
If given, it should be correct. Throw exception if Duration (
Duration.parse(amountToShift);) can not be created.
test to change: TestTimeShiftFunction.testWrongAmountToAdd()

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to