[ 
https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935768#action_12935768
 ] 

Dave Brosius commented on KARAF-299:
------------------------------------

darn it, you're right, my apologies.

perhaps it's supposed to be this (if so i've applied a new patch):

    public Set<Feature> getFeaturesContainingBundle (Bundle bundle) throws 
Exception {
        Set<Feature> features = new HashSet<Feature>();
        for (Map<String, Feature> featureMap : this.getFeatures().values()) {
            for (Feature f : featureMap.values()) {
                for (BundleInfo bi : f.getBundles()) {
                    if (bi.getLocation().equals(bundle.getLocation())) {
                        features.add(f);
                        break;
                    }
                }
            }
        }
        return features;
    }

> [patch] miscellaneous cleanups
> ------------------------------
>
>                 Key: KARAF-299
>                 URL: https://issues.apache.org/jira/browse/KARAF-299
>             Project: Karaf
>          Issue Type: Bug
>         Environment: ubuntu 10.10 java1.6.17
>            Reporter: Dave Brosius
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: bundleprobs.diff, fixes.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to