[
https://issues.apache.org/jira/browse/KARAF-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970538#action_12970538
]
Andreas Pieber commented on KARAF-309:
--------------------------------------
I've taken a look at the commit; basically it works for me, but the following
points:
1) you've put the jetty.xml to assembly/src/main/jettyconfig; shouldn't we put
it to assembly/src/main/configfiles/jetty.xml or something similar. I'm sure
we'll see more configs in near future :)
2) I'm not so sure about the file path in features.xml
(${karaf.home}/etc/jetty.xml). Well, first I don't think that we should allow
any other path than ${karaf.home}. (Imagine that someone writes a feature which
uses C:\windows\system32 here...) In addition I also think that we should not
allow to write in all directories. Maybe we should only allow the configs in
${karaf.home}/etc? But not sure about this; maybe there are usecases...
3) BTW if someone wants to store his file in
${karaf.home}/etc/someotherfolder/file.xml your algorithmus will fail. You have
to do something like file.getParentFile().mkDirs(); first, before you do
file.createNewFile();
4) I'm not sure, but IMHO the maven-tooling-plugin should also install the
config file during the "add-features-to-repo" mojo?
WDYT?
> Provide jetty.xml with preconfigured JAAS Authentication.
> ---------------------------------------------------------
>
> Key: KARAF-309
> URL: https://issues.apache.org/jira/browse/KARAF-309
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Achim Nierbeck
> Assignee: Achim Nierbeck
> Priority: Minor
>
> The provided jetty.xml could look like this:
> {code}
> <?xml version="1.0"?>
> <!DOCTYPE Configure PUBLIC "-//Mort Bay Consulting//
> DTD Configure//EN" "http://jetty.mortbay.org/configure.dtd";>
> <Configure class="org.eclipse.jetty.server.Server">
> <!-- =========================================================== -->
> <!-- Set connectors -->
> <!-- =========================================================== -->
> <!-- One of each type! -->
> <!-- =========================================================== -->
> <!-- Use this connector for many frequently idle connections
> and for threadless continuations.
> -->
> <Call name="addConnector">
> <Arg>
> <New class="org.eclipse.jetty.server.nio.SelectChannelConnector">
> <Set name="host"><Property name="jetty.host" /></Set>
> <!-- default port will be overwritten by pax-web
> configuration -->
> <Set name="port"><Property name="jetty.port"
> default="8080"/></Set>
> <Set name="maxIdleTime">300000</Set>
> <Set name="Acceptors">2</Set>
> <Set name="statsOn">false</Set>
> <Set name="confidentialPort">8443</Set>
> <Set name="lowResourcesConnections">20000</Set>
> <Set name="lowResourcesMaxIdleTime">5000</Set>
> </New>
> </Arg>
> </Call>
>
> <!-- =========================================================== -->
> <!-- Configure Authentication Realms -->
> <!-- Realms may be configured for the entire server here, or -->
> <!-- they can be configured for a specific web app in a context -->
> <!-- configuration (see $(jetty.home)/contexts/test.xml for an -->
> <!-- example). -->
> <!-- =========================================================== -->
> <!-- Enable this after jetty-jaas feature has been installed -->
> <!--
> <Call name="addBean">
> <Arg>
> <New class="org.eclipse.jetty.plus.jaas.JAASLoginService">
> <Set name="name">karaf</Set>
> <Set name="loginModuleName">karaf</Set>
> <Set name="roleClassNames">
> <Array type="java.lang.String">
>
> <Item>org.apache.karaf.jaas.modules.RolePrincipal</Item>
> </Array>
> </Set>
> </New>
> </Arg>
> </Call>
> -->
> </Configure>
> {code}
> Installing an optional configuration file attached to a feature could be done
> like this:
> {code}
> <feature ...>
> <configfile
> finalname="etc/xyz.xml">mvn:groupId/artifactId/xml/jettyconfig</configfile>
> </feature>
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
