[
https://issues.apache.org/jira/browse/KARAF-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092735#comment-13092735
]
Łukasz Dywicki commented on KARAF-374:
--------------------------------------
Since we talk about commands I think that output printed from commands comes
from user interaction. When somebody execute command the System.out in fact is
used as getConsole.println(). In case of any exceptions commands log them to
karaf.log so I don't think that wrapper.log is relevant here.
> Clean up commands and remove System.out from them, simplify JANSI usage.
> ------------------------------------------------------------------------
>
> Key: KARAF-374
> URL: https://issues.apache.org/jira/browse/KARAF-374
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-shell
> Affects Versions: 2.1.2
> Reporter: Łukasz Dywicki
> Assignee: Łukasz Dywicki
> Fix For: 3.1.0
>
>
> Currently we have two bad things in our commands. First is
> System.out.println() mix with getConsole().println()
> Second thing is jansi usage. It is really cool to have colour output under
> Windows/Unix shell but printing something with this library is a little hard.
> Fluent api in this case is not the best choice:
> String str = Ansi.ansi()
> .fg(Ansi.Color.RED)
> .a("Command not found: ")
> .a(Ansi.Attribute.INTENSITY_BOLD)
> .a(((CommandNotFoundException) t).getCommand())
> .a(Ansi.Attribute.INTENSITY_BOLD_OFF)
> .fg(Ansi.Color.DEFAULT).toString();
> Instead of simple string tags:
> String str = new Ansi("[red]Command not found: [bold]" +
> ((CommandNotFoundException) t).getCommand() + "[/bold][/red]).toString();
> These two things are releated because we can simply wrap
> getConsole().println() with jansi but System.out.println not.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
