Tightening up of cave:remove-repository and register-repository commands
------------------------------------------------------------------------
Key: KARAF-974
URL: https://issues.apache.org/jira/browse/KARAF-974
Project: Karaf
Issue Type: Improvement
Components: cave-repository
Affects Versions: cave-3.0.0
Reporter: Glen Mazza
Fix For: cave-3.0.0
Attachments: cavePatch.patch
The attached Cave patch makes the following changes:
1.) Provides a -help function for cave:remove-repository (instead of NPE)
2.) Reports an error if cave "name" parameter to cave:remove-repository is
either null or does not exist. (instead of silence/NPE)
3.) For cave:remove-repository, also unregisters the Cave repository from the
OBR if the repo was registered there
4.) For cave:register-repository, reports an error if the repo doesn't exist
(instead of NPE).
You can test the patch with these commands:
karaf@root> features:addurl
mvn:org.apache.karaf.cave/apache-karaf-cave/3.0.0-SNAPSHOT/xml/features
karaf@root> features:install cave-server
(1) karaf@root> cave:remove-repository --help
DESCRIPTION
cave:remove-repository
Remove a Karaf Cave repository from the Cave repository list
SYNTAX
cave:remove-repository [options] name
ARGUMENTS
name
The Karaf Cave repository name
OPTIONS
--help
Display this help message
karaf@root> cave:create-repository repo1
karaf@root> cave:create-repository -nr repo2
karaf@root> obr:listurl
file:/media/NewDriveExt3_/underthehood/apache-karaf-2.2.4/cave/repo1/repository.xml
(2) karaf@root> cave:remove-repository
Error executing command cave:remove-repository: argument name is required
(2) karaf@root> cave:remove-repository repodoesntexist
Error executing command: Cave repository repodoesntexist not found.
karaf@root> cave:list-repositories
Name Location
[repo1]
[/media/NewDriveExt3_/underthehood/apache-karaf-2.2.4/cave/repo1]
[repo2]
[/media/NewDriveExt3_/underthehood/apache-karaf-2.2.4/cave/repo2]
karaf@root> cave:remove-repository repo2
karaf@root> cave:list-repositories
Name Location
[repo1]
[/media/NewDriveExt3_/underthehood/apache-karaf-2.2.4/cave/repo1]
karaf@root> obr:listurl
file:/media/NewDriveExt3_/underthehood/apache-karaf-2.2.4/cave/repo1/repository.xml
karaf@root> cave:remove-repository repo1
(3) karaf@root> obr:listurl
No repository URLs are set.
(4) karaf@root> cave:register-repository repodoesntexist
Error executing command: Cave repository repodoesntexist not found.
karaf@root> cave:create-repository -nr repo3
karaf@root> cave:list-repositories
Name Location
[repo3]
[/media/NewDriveExt3_/underthehood/apache-karaf-2.2.4/cave/repo3]
karaf@root> obr:listurl
No repository URLs are set.
karaf@root> cave:register-repository repo3
karaf@root> obr:listurl
file:/media/NewDriveExt3_/underthehood/apache-karaf-2.2.4/cave/repo3/repository.xml
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
