[ 
https://issues.apache.org/jira/browse/KARAF-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213674#comment-13213674
 ] 

Achim Nierbeck commented on KARAF-1218:
---------------------------------------

regarding the file-installer, afaik since it uses a service-factory, a thread 
is created for every configuration found, so basically if you add another 
configuration for another directory you end up with another thread. Another 
thing, each of the file-installer thread can be configured differently 
regarding scheduling and file-filtering. So I'd guess we better stick to those 
two threads left over. 
                
> Only use 1 thread for file installer watcher
> --------------------------------------------
>
>                 Key: KARAF-1218
>                 URL: https://issues.apache.org/jira/browse/KARAF-1218
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 2.2.5
>            Reporter: Claus Ibsen
>            Priority: Minor
>
> When running Apache Karaf 2.2.5 then we want to run it with as low overhead 
> as possible. Out of the box it has around 30+ live threads running, which is 
> a fair bit.
> We should try to consolidate if applicable. For example there is 2 separate 
> threads for picking up file installer. This can be implemented as a single 
> thread instead.
> {code}
> "fileinstall-/opt/apache-karaf-2.2.5/deploy" daemon prio=5 tid=7fa0cc26d800 
> nid=0x1104ec000 in Object.wait() [1104eb000]
>    java.lang.Thread.State: TIMED_WAITING (on object monitor)
>       at java.lang.Object.wait(Native Method)
>       - waiting on <7e0690610> (a 
> org.apache.felix.fileinstall.internal.DirectoryWatcher)
>       at 
> org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:268)
>       - locked <7e0690610> (a 
> org.apache.felix.fileinstall.internal.DirectoryWatcher)
> "fileinstall-/opt/apache-karaf-2.2.5/etc" daemon prio=5 tid=7fa0cc26a800 
> nid=0x1103e9000 in Object.wait() [1103e8000]
>    java.lang.Thread.State: TIMED_WAITING (on object monitor)
>       at java.lang.Object.wait(Native Method)
>       - waiting on <7e068e778> (a 
> org.apache.felix.fileinstall.internal.DirectoryWatcher)
>       at 
> org.apache.felix.fileinstall.internal.DirectoryWatcher.run(DirectoryWatcher.java:268)
>       - locked <7e068e778> (a 
> org.apache.felix.fileinstall.internal.DirectoryWatcher)
> {code}
> Those 2 thread should be a single thread, that just watches the 2 directories.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to