[ 
https://issues.apache.org/jira/browse/KARAF-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286675#comment-13286675
 ] 

Benjamin Reed commented on KARAF-1514:
--------------------------------------

Here's a simple set of maven projects that lays things out:

https://github.com/RangerRick/karaf-test-cases/tree/4349700d1d8d61a767d96a167da8cab97db36815

Right now, everything looks exactly as expected, except features/02's 
features.xml is missing the <feature> dependency on feature-01, and it's adding 
a wrap:mvn for the feature-01 pom.

ie, current output:


<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<features xmlns="http://karaf.apache.org/xmlns/features/v1.0.0"; 
name="feature-02">
    <feature description="Feature Test Case 01 (3rd-Party Dependencies)" 
name="feature-01">
        <bundle>mvn:org.apache.commons/commons-exec/1.1</bundle>
    </feature>
    <feature description="Feature Test Case 02 (Bundle + 3rd-Party 
Dependencies)" name="feature-02">
        
<bundle>mvn:com.example.test.bundles/com.example.test.api/1.0-SNAPSHOT</bundle>
        
<bundle>mvn:com.example.test.bundles/com.example.test.execthing/1.0-SNAPSHOT</bundle>
        
<bundle>wrap:mvn:com.example.test.features/feature-01/1.0-SNAPSHOT/pom</bundle>
    </feature>
</features>


expected output if <scope>feature</scope> worked as a dependency:


<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<features xmlns="http://karaf.apache.org/xmlns/features/v1.0.0"; 
name="feature-02">
    <feature description="Feature Test Case 01 (3rd-Party Dependencies)" 
name="feature-01">
        <bundle>mvn:org.apache.commons/commons-exec/1.1</bundle>
    </feature>
    <feature description="Feature Test Case 02 (Bundle + 3rd-Party 
Dependencies)" name="feature-02">
        
<bundle>mvn:com.example.test.bundles/com.example.test.api/1.0-SNAPSHOT</bundle>
        
<bundle>mvn:com.example.test.bundles/com.example.test.execthing/1.0-SNAPSHOT</bundle>
        <feature>feature-01</feature>
    </feature>
</features>
                
> Improve feature file generation to be able to create features out of special 
> feature poms
> -----------------------------------------------------------------------------------------
>
>                 Key: KARAF-1514
>                 URL: https://issues.apache.org/jira/browse/KARAF-1514
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Christian Schneider
>
> Currently we have no way to describe several features without having a 
> template feature file.
> To improve that we could describe a single feature as a pom which can depend 
> on other poms and jars. We could then create another pom for the feature file 
> which depends on the feature poms with scope feature. So the plugin would 
> know to create a feature for each pom of scope feature. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to