[
https://issues.apache.org/jira/browse/KARAF-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410294#comment-13410294
]
Jamie goodyear commented on KARAF-1572:
---------------------------------------
So I've been reviewing the patch, and can see the general direction the code is
going in.
There are a few things I'd like to see modified:
- remove copy & paste code (acquireLock and stealLock are essentially the same)
- reduce usage of magic numbers (setInt calls)
- we try to not set values in main, we read from configs
- reduce comments, they tend to not be maintained
Also, I would not call this a default strategy, perhaps nonLongTxLock or the
like. Users whom can not use the default strategy can then select the
alternative.
> Add SQL Server Support for JDBC Lock
> -------------------------------------
>
> Key: KARAF-1572
> URL: https://issues.apache.org/jira/browse/KARAF-1572
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-instance
> Affects Versions: 2.2.7
> Reporter: Claudio Corsi
> Fix For: 2.2.9, 2.3.1, 3.1.0
>
> Attachments: GenericJDBCLock.patch
>
>
> The current JDBCLock implementations do not work when using Microsoft SQL
> Server since this requires that you use a CURSOR with the SELECT statement.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
