[ 
https://issues.apache.org/jira/browse/KARAF-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Lazebny reopened KARAF-2820:
---------------------------------


After some changes doesn't work again. I have tried sample pom.xml with latest 
snapshot  today

> features-maven-plugin:add-features-to-repo adds wrong transitive feature 
> version
> --------------------------------------------------------------------------------
>
>                 Key: KARAF-2820
>                 URL: https://issues.apache.org/jira/browse/KARAF-2820
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-tooling
>    Affects Versions: 2.3.4
>            Reporter: Igor Lazebny
>            Assignee: Freeman Fang
>             Fix For: 2.4.0, 3.0.1, 3.1.0, 2.3.5
>
>         Attachments: pom.xml
>
>
> features-maven-plugin:add-features-to-repo tries to find greatest version of 
> transitive feature to add. But the problem is it compares versions as string. 
> So, for example, "2.7.7" > "2.7.10".
> Here is that part in 
> tooling/features-maven-plugin/src/main/java/org/apache/karaf/tooling/features/AddFeaturesToRepoMojo.java
>  313                 // looking for the feature name (with the greatest 
> version)
> 314                 for (String key : featuresMap.keySet()) {
> 315                     String[] nameVersion = key.split("/");
> 316                     if (feature.equals(nameVersion[0])) {
> 317                         if (f == null || 
> f.getVersion().compareTo(featuresMap.get(key).getVersion()) < 0) {
> 318                             f = featuresMap.get(key);
> 319                         }
> 320                     }
> 321                 }
> I have an example, which adds 2 features: cxf (2.7.10) and camel (2.12.2). 
> Expected result: 2.7.10 CXF bundles in target/features-repo. Actual result: 
> 2.7.7 CXF bundles - as transitive through Camel features descriptor.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to