[ 
https://issues.apache.org/jira/browse/KARAF-3035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182645#comment-14182645
 ] 

Guillaume Nodet commented on KARAF-3035:
----------------------------------------

A few problems I found in the patch:
  * it does not apply to any branch of Karaf as is ...
  * pax-jdbc does not seem to be used at all, so imho, we should remove the 
dependency, or actually use it by creating a factory configuration instead of 
publishing a blueprint.  This may considered a new feature for 4.x, but then we 
should not have to depend on pax-jdbc
  * I wonder if the data sources definition should look like the following to 
provide recovery and avoid being managed again by aries

{code}
    <reference id="transactionManager" 
interface="org.apache.aries.transaction.AriesTransactionManager"/>

    <jdbc:recoverableDataSource bp:id="pooledDataSource"
                                name="${name}"
                                dataSource="#dataSource"
                                transactionManager="#transactionManager"
                                username="${user}"
                                password="${password}"/>

    <service ref="pooledDataSource" interface="javax.sql.DataSource">
        <service-properties>
            <entry key="osgi.jndi.service.name" value="jdbc/${name}"/>
            <entry key="aries.managed" value="true"/>
        </service-properties>
    </service>
{code}

> Use aries transaction jdbc / jms for pooling
> --------------------------------------------
>
>                 Key: KARAF-3035
>                 URL: https://issues.apache.org/jira/browse/KARAF-3035
>             Project: Karaf
>          Issue Type: Improvement
>    Affects Versions: 4.0.0
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: 4.0.0, 3.0.3, 2.4.1, 2.3.9
>
>         Attachments: vcs-diff1271163984438294153.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to