Jan-Peter Nilsson created KARAF-3656:
----------------------------------------
Summary: SSH message channel closed too early
Key: KARAF-3656
URL: https://issues.apache.org/jira/browse/KARAF-3656
Project: Karaf
Issue Type: Bug
Components: karaf-shell
Affects Versions: 4.0.0.M2, 2.3.10, 2.4.1, 3.0.3
Reporter: Jan-Peter Nilsson
Priority: Minor
Using SSH exec with Karaf 2.3.10 SSH_MSG_CHANNEL_SUCCESS is sent after
SSH_MSG_CHANNEL_CLOSE in the response.
This causes problems when trying to use the Paramiko SSH client library as it
will close the channel on receiving SSH_MSG_CHANNEL_CLOSE and considers it a
failure if SSH_MSG_CHANNEL_SUCCESS was not received.
{code:title=reproduce.py|borderStyle=solid}
#!/usr/bin/python
import paramiko
client = paramiko.SSHClient()
client.set_missing_host_key_policy(paramiko.AutoAddPolicy())
client.load_system_host_keys()
client.connect('localhost', port=8101, username="karaf", password="karaf")
client.exec_command('help')
# Throws SSHException "Channel closed." for affected versions.
{code}
The reason SUCCESS and CLOSE come out of order seems to be that start in the
ShellCommand class does not spawn a separate thread but calls the onExit
callback from within the same thread, see
[SSHD-295|https://issues.apache.org/jira/browse/SSHD-295] and the [Apache MINA
SSHD
API|http://mina.apache.org/sshd-project/apidocs/org/apache/sshd/server/Command.html#start-org.apache.sshd.server.Environment-].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
