[ 
https://issues.apache.org/jira/browse/KARAF-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Markus Rathgeb updated KARAF-4055:
----------------------------------
    Description: 
The feature XML generation fails if the source feature XML contains a @ (e.g. 
in the comment).
This is very annoying if your project is using the a maven license plugin and 
the license contains an email address of your company.

The current mechanism does replace ${...} and @...@ in the XML.
IMHO we should drop the @...@ support, so we could use email addresses in 
comments (e.g. licenses).

The problem could be reproduced using the "normal" output of the feature 
archetype.
Add a @ to the license header of the "src/main/feature/feature.xml" and run a 
"mvn clean install".

The result looks like:
<pre>
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<features xmlns="http://karaf.apache.org/xmlns/features/v1.3.0"; 
name="${project.artifactId}-${project.version}">
    <feature name="${project.artifactId}" description="${project.name}" 
version="0.0.0.__project_version_">
        <details>${project.description}</details>
    </feature>
</features>
</pre>

  was:
The feature XML generation fails if the source feature XML contains a @ (e.g. 
in the comment).
This is very annoying if your project is using the a maven license plugin and 
the license contains an email address of your company.

The current mechanism does replace ${...} and @...@ in the XML.
IMHO we should drop the @...@ support, so we could use email addresses in 
comments (e.g. licenses).

The problem could be reproduced using the "normal" output of the feature 
archetype.
Add a @ to the license header of the "src/main/feature/feature.xml" and run a 
"mvn clean install".

The result looks like:
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<features xmlns="http://karaf.apache.org/xmlns/features/v1.3.0"; 
name="${project.artifactId}-${project.version}">
    <feature name="${project.artifactId}" description="${project.name}" 
version="0.0.0.__project_version_">
        <details>${project.description}</details>
    </feature>
</features>



> karaf-maven-plugin: feature XML with a @ character
> --------------------------------------------------
>
>                 Key: KARAF-4055
>                 URL: https://issues.apache.org/jira/browse/KARAF-4055
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf-tooling
>    Affects Versions: 4.0.0, 4.0.1
>            Reporter: Markus Rathgeb
>
> The feature XML generation fails if the source feature XML contains a @ (e.g. 
> in the comment).
> This is very annoying if your project is using the a maven license plugin and 
> the license contains an email address of your company.
> The current mechanism does replace ${...} and @...@ in the XML.
> IMHO we should drop the @...@ support, so we could use email addresses in 
> comments (e.g. licenses).
> The problem could be reproduced using the "normal" output of the feature 
> archetype.
> Add a @ to the license header of the "src/main/feature/feature.xml" and run a 
> "mvn clean install".
> The result looks like:
> <pre>
> <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> <features xmlns="http://karaf.apache.org/xmlns/features/v1.3.0"; 
> name="${project.artifactId}-${project.version}">
>     <feature name="${project.artifactId}" description="${project.name}" 
> version="0.0.0.__project_version_">
>         <details>${project.description}</details>
>     </feature>
> </features>
> </pre>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to