[
https://issues.apache.org/jira/browse/KARAF-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095542#comment-15095542
]
Freeman Fang commented on KARAF-4157:
-------------------------------------
Hi Luca,
Thanks for the contribution, I like it.
The scripts looks good to me, just some little things
1. we need ship these scripts in Karaf distribution kit so that we can use
these scripts easily to create the service launch script from kit
2. the karaf-service-win.xml has fixed 4.0.3 kit path, we need fix this,
something like filter the path when we include these scripts in kit
3. in the karaf-service.sh, you have a function named
genrate_service_descriptor, I think it should be generate_service_descriptor
4. in the help message of karaf-service.sh, it has
{code}
USAGE: ./karaf-service.sh [-f KARAF_SERVICE_PATH] [-d KARAF_SERVICE_DATA] [-p
KARAF_SERVICE_PIDFILE] [-n KARAF_SERVICE_NAME] [-e KARAF_ENV, ...]
-k KARAF_SERVICE_PATH # Karaf installation path
{code}
the "-f KARAF_SERVICE_PATH" should be "-k KARAF_SERVICE_PATH " to keep the
consistence.
5. if we can add the executable flag for the auto-generated service script,
that would be great.
Could you please add another commit for your PR to address the above I
mentioned?
Thanks
Freeman
> Provide system script to start Karaf without service wrapper
> ------------------------------------------------------------
>
> Key: KARAF-4157
> URL: https://issues.apache.org/jira/browse/KARAF-4157
> Project: Karaf
> Issue Type: New Feature
> Reporter: Luca Burgazzoli
> Assignee: Freeman Fang
> Priority: Minor
>
> For some user/scenario it may be needed to start karaf as a service without
> the service wrapper i.e. on architectures not supported by JSW
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
