[
https://issues.apache.org/jira/browse/KARAF-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110734#comment-15110734
]
ASF GitHub Bot commented on KARAF-4288:
---------------------------------------
GitHub user mcculls opened a pull request:
https://github.com/apache/karaf/pull/136
KARAF-4288 - pass custom settings.xml onto pax-url-aether
https://issues.apache.org/jira/browse/KARAF-4288
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcculls/karaf
KARAF-4288-support-custom-settings-xml
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/karaf/pull/136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #136
----
commit 8d5765046602adbc36de4fadb8c88882fb421bd1
Author: Stuart McCulloch <[email protected]>
Date: 2016-01-21T15:06:50Z
KARAF-4288 - pass custom settings.xml onto pax-url-aether
----
> karaf-maven-plugin doesn't pass custom settings.xml option onto pax-url-aether
> ------------------------------------------------------------------------------
>
> Key: KARAF-4288
> URL: https://issues.apache.org/jira/browse/KARAF-4288
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 4.0.4
> Reporter: Stuart McCulloch
> Attachments: KARAF-4288.patch
>
>
> When adding features to a custom distribution karaf-maven-plugin uses
> pax-url-aether to fetch artifacts which don't yet exist in the local maven
> repository.
> pax-url-aether has logic to discover the local repository and settings.xml
> file, but this relies on defaults plus a few heuristics. If a Maven build
> uses a custom settings.xml file which contains auth details, ie. when running
> on CI, then this is not picked up by pax-url-aether and it cannot fetch down
> additional content.
> The current user settings file is accessible from the MavenSession:
> MavenSession->getRequest->getUserSettingsFile
> and the session is available from the mojo. All that needs to be done is pass
> on this path to pax-url-aether by setting the
> "org.ops4j.pax.url.mvn.settings" system property. (Note the user settings
> file may be null or may not exist, in which case the global settings path
> should be passed to pax-url-aether)
> (I'll attach a patch that implements this suggested solution)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
