[
https://issues.apache.org/jira/browse/KARAF-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034505#comment-16034505
]
ASF GitHub Bot commented on KARAF-5173:
---------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/karaf/pull/310
> Some tests could benefit from a common CallbackHandler
> ------------------------------------------------------
>
> Key: KARAF-5173
> URL: https://issues.apache.org/jira/browse/KARAF-5173
> Project: Karaf
> Issue Type: Improvement
> Components: karaf-core
> Affects Versions: 4.2.0
> Reporter: Stephen Kitt
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 4.2.0
>
>
> I’ve noticed that a number of tests contain code like
> {code}
> CallbackHandler cb = new CallbackHandler() {
> public void handle(Callback[] callbacks) throws IOException,
> UnsupportedCallbackException {
> for (Callback cb : callbacks) {
> if (cb instanceof NameCallback) {
> ((NameCallback) cb).setName("hnelson");
> } else if (cb instanceof PasswordCallback) {
> ((PasswordCallback)
> cb).setPassword("secret".toCharArray());
> }
> }
> }
> };
> {code}
> It might make sense to introduce a concrete implementation of CallbackHandler
> to provide this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
