[
https://issues.apache.org/jira/browse/KARAF-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329030#comment-16329030
]
ASF GitHub Bot commented on KARAF-5561:
---------------------------------------
jbonofre closed pull request #43: [KARAF-5561] Fixed typo in category name
URL: https://github.com/apache/karaf-cellar/pull/43
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/bundle/src/main/java/org/apache/karaf/cellar/bundle/BundleEventHandler.java
b/bundle/src/main/java/org/apache/karaf/cellar/bundle/BundleEventHandler.java
index 8916b4f6..c2f7da6e 100644
---
a/bundle/src/main/java/org/apache/karaf/cellar/bundle/BundleEventHandler.java
+++
b/bundle/src/main/java/org/apache/karaf/cellar/bundle/BundleEventHandler.java
@@ -79,7 +79,7 @@ public void handle(ClusterBundleEvent event) {
// check the features first
List<Feature> matchingFeatures =
retrieveFeature(event.getLocation());
for (Feature feature : matchingFeatures) {
- if (!isAllowed(event.getSourceGroup(), "features",
feature.getName(), EventType.INBOUND)) {
+ if (!isAllowed(event.getSourceGroup(), "feature",
feature.getName(), EventType.INBOUND)) {
LOGGER.trace("CELLAR BUNDLE: bundle {} is contained in
feature {} marked BLOCKED INBOUND for cluster group {}", event.getLocation(),
feature.getName(), event.getSourceGroup().getName());
return;
}
diff --git
a/bundle/src/main/java/org/apache/karaf/cellar/bundle/LocalBundleListener.java
b/bundle/src/main/java/org/apache/karaf/cellar/bundle/LocalBundleListener.java
index bfb7de0a..ea8a1c4e 100644
---
a/bundle/src/main/java/org/apache/karaf/cellar/bundle/LocalBundleListener.java
+++
b/bundle/src/main/java/org/apache/karaf/cellar/bundle/LocalBundleListener.java
@@ -121,7 +121,7 @@ public void bundleChanged(BundleEvent event) {
// check the features first
List<Feature> matchingFeatures =
retrieveFeature(bundleLocation);
for (Feature feature : matchingFeatures) {
- if (!isAllowed(group,
"features", feature.getName(), EventType.OUTBOUND)) {
+ if (!isAllowed(group,
"feature", feature.getName(), EventType.OUTBOUND)) {
LOGGER.trace("CELLAR
BUNDLE: bundle {} is contained in feature {} marked BLOCKED OUTBOUND for
cluster group {}", bundleLocation, feature.getName(), group.getName());
return;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Typo in hazelcast group name prevent blacklist/whitelist to be checked
> ----------------------------------------------------------------------
>
> Key: KARAF-5561
> URL: https://issues.apache.org/jira/browse/KARAF-5561
> Project: Karaf
> Issue Type: Bug
> Components: cellar-bundle
> Affects Versions: cellar-4.0.4, cellar-4.1.1
> Reporter: Thomas Draier
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: cellar-4.0.5, cellar-4.1.2
>
>
> The "category" parameter passed to isAllowed() is set to "features" instead
> of "feature" in BundleEventHandler and LocalBundleListener, which makes the
> code ignore the features whitelist/blacklist in these 2 cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
