[
https://issues.apache.org/jira/browse/KARAF-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413751#comment-16413751
]
ASF GitHub Bot commented on KARAF-5384:
---------------------------------------
gnodet closed pull request #477: [KARAF-5384] Installing MINA SSHD Core cause
system bundle refreshes
URL: https://github.com/apache/karaf/pull/477
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/assemblies/features/standard/src/main/feature/feature.xml
b/assemblies/features/standard/src/main/feature/feature.xml
index 2036e1891a..6e963255d5 100644
--- a/assemblies/features/standard/src/main/feature/feature.xml
+++ b/assemblies/features/standard/src/main/feature/feature.xml
@@ -120,7 +120,7 @@
openjpa=mvn:org.apache.openjpa/openjpa-features/RELEASE/xml/features
artemis=mvn:org.apache.activemq/artemis-features/RELEASE/xml/features
brave=mvn:io.zipkin.brave.karaf/brave-features/RELEASE/xml/features
-
sling=mvn:org.apache.sling/org.apache.sling.karaf-features/RELEASE/xml/features
+
sling=mvn:org.apache.sling/org.apache.sling.karaf-features/RELEASE/xml/features
</config>
<conditional>
<condition>shell</condition>
@@ -353,12 +353,19 @@
# moduli-url = external moduli-url users wanna use
</config>
- <bundle dependency="true"
start-level="30">mvn:org.fusesource.jansi/jansi/${jansi.version}</bundle>
- <bundle dependency="true"
start-level="30">mvn:org.jline/jline/${jline.version}</bundle>
+ <feature>jline</feature>
<bundle
start-level="30">mvn:org.apache.karaf.shell/org.apache.karaf.shell.core/${project.version}</bundle>
<bundle
start-level="30">mvn:org.apache.karaf.shell/org.apache.karaf.shell.commands/${project.version}</bundle>
</feature>
+ <feature name="jline" version="${jline.version}" hidden="true">
+ <bundle dependency="true"
start-level="30">mvn:org.fusesource.jansi/jansi/${jansi.version}</bundle>
+ <bundle
start-level="30">mvn:org.jline/jline-terminal/${jline.version}</bundle>
+ <bundle
start-level="30">mvn:org.jline/jline-terminal-jansi/${jline.version}</bundle>
+ <bundle
start-level="30">mvn:org.jline/jline-reader/${jline.version}</bundle>
+ <bundle
start-level="30">mvn:org.jline/jline-builtins/${jline.version}</bundle>
+ </feature>
+
<feature name="shell-compat" description="Karaf Shell Compatibility"
version="${project.version}">
<feature>aries-blueprint</feature>
<feature>shell</feature>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optional dependencies in MINA SSHD Core cause system bundle refreshes
> ---------------------------------------------------------------------
>
> Key: KARAF-5384
> URL: https://issues.apache.org/jira/browse/KARAF-5384
> Project: Karaf
> Issue Type: Bug
> Components: karaf-core
> Affects Versions: 4.1.0, 4.1.1, 4.1.2
> Environment: Fedora Linux
> Reporter: Seth Leger
> Assignee: Guillaume Nodet
> Priority: Critical
> Fix For: 4.2.1
>
>
> In similar fashion to KARAF-5251, if you install any feature in Karaf that
> includes:
> - Apache MINA
> - bouncycastle
> - net.i2p.crypto
> it will cause the MINA SSHD Core bundle to refresh, which in turn refreshes
> most of the core framework bundles. This has a variety of bad effects
> including:
> - Terminating the current SSH session
> - Terminating subsequent feature installations
> This is more severe than KARAF-5251 because these libraries are not part of
> the core Karaf distro so it is not possible to add them to
> {{startup.properties}} without first repackaging Karaf to contain the desired
> bundles in the {{/system}} directory.
> This also makes testing any Karaf feature that contains MINA, bouncycastle,
> or net.i2p.crypto impossible in Pax Exam (unless you use
> org.apache.karaf.features.FeaturesService.Option.NoAutoRefreshBundles or
> feature:install -r) because the refresh invalidates @Inject references in
> your test as the core bundles are refreshed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
