[
https://issues.apache.org/jira/browse/KARAF-5840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561423#comment-16561423
]
ASF GitHub Bot commented on KARAF-5840:
---------------------------------------
jbonofre closed pull request #581: [KARAF-5840] Add endorsed and ext dirs by
default in wrapper
URL: https://github.com/apache/karaf/pull/581
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/unix/karaf-wrapper.conf
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/unix/karaf-wrapper.conf
index 2b2f2a05be..aea1487546 100644
---
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/unix/karaf-wrapper.conf
+++
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/unix/karaf-wrapper.conf
@@ -37,17 +37,19 @@ wrapper.java.library.path.1=%KARAF_BASE%/lib/wrapper/
# JVM Parameters
# note that n is the parameter number starting from 1.
-wrapper.java.additional.1=-Dkaraf.home=%KARAF_HOME%
-wrapper.java.additional.2=-Dkaraf.base=%KARAF_BASE%
-wrapper.java.additional.3=-Dkaraf.data=%KARAF_DATA%
-wrapper.java.additional.4=-Dkaraf.etc=%KARAF_ETC%
-wrapper.java.additional.5=-Dcom.sun.management.jmxremote
-wrapper.java.additional.6=-Dkaraf.startLocalConsole=false
-wrapper.java.additional.7=-Dkaraf.startRemoteShell=true
-wrapper.java.additional.8=-Djava.io.tmpdir=%KARAF_DATA%/tmp
-# Uncomment if you need libraries on Java 8
-#wrapper.java.additional.9=-Djava.endorsed.dirs=%JAVA_HOME%/jre/lib/endorsed:%JAVA_HOME%/lib/endorsed:%KARAF_HOME%/lib/endorsed
-#wrapper.java.additional.10=-Djava.ext.dirs=%JAVA_HOME%/jre/lib/ext:%JAVA_HOME%/lib/ext:%KARAF_HOME%/lib/ext
+wrapper.java.additional.1=-Djava.endorsed.dirs=%JAVA_HOME%/jre/lib/endorsed:%JAVA_HOME%/lib/endorsed:%KARAF_HOME%/lib/endorsed
+wrapper.java.additional.2=-Djava.ext.dirs=%JAVA_HOME%/jre/lib/ext:%JAVA_HOME%/lib/ext:%KARAF_HOME%/lib/ext
+wrapper.java.additional.3=-Dkaraf.instances=%KARAF_HOME%/instances
+wrapper.java.additional.4=-Dkaraf.home=%KARAF_HOME%
+wrapper.java.additional.5=-Dkaraf.base=%KARAF_BASE%
+wrapper.java.additional.6=-Dkaraf.data=%KARAF_DATA%
+wrapper.java.additional.7=-Dkaraf.etc=%KARAF_ETC%
+wrapper.java.additional.8=-Dkaraf.restart.jvm.supported=true
+wrapper.java.additional.9=-Djava.io.tmpdir=%KARAF_DATA%/tmp
+wrapper.java.additional.10=-Djava.util.logging.config.file=%KARAF_BASE%/etc/java.util.logging.properties
+wrapper.java.additional.11=-Dcom.sun.management.jmxremote
+wrapper.java.additional.12=-Dkaraf.startLocalConsole=false
+wrapper.java.additional.13=-Dkaraf.startRemoteShell=true
# Uncomment to enable jmx
#wrapper.java.additional.n=-Dcom.sun.management.jmxremote.port=1616
diff --git
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
index 51a18772fb..b528acd0ae 100644
---
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
+++
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows/karaf-wrapper.conf
@@ -37,17 +37,19 @@ wrapper.java.library.path.1=%KARAF_BASE%/lib/wrapper/
# JVM Parameters
# note that n is the parameter number starting from 1.
-wrapper.java.additional.1=-Dkaraf.home="%KARAF_HOME%"
-wrapper.java.additional.2=-Dkaraf.base="%KARAF_BASE%"
-wrapper.java.additional.3=-Dkaraf.data="%KARAF_DATA%"
-wrapper.java.additional.4=-Dkaraf.etc="%KARAF_ETC%"
-wrapper.java.additional.5=-Dcom.sun.management.jmxremote
-wrapper.java.additional.6=-Dkaraf.startLocalConsole=false
-wrapper.java.additional.7=-Dkaraf.startRemoteShell=true
-wrapper.java.additional.8=-Djava.io.tmpdir="%KARAF_DATA%/tmp"
-# Uncomment if you need libraries on Java 8
-#wrapper.java.additional.9=-Djava.endorsed.dirs="%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed"
-#wrapper.java.additional.10=-Djava.ext.dirs="%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext"
+wrapper.java.additional.1=-Djava.endorsed.dirs=%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed
+wrapper.java.additional.2=-Djava.ext.dirs=%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext
+wrapper.java.additional.3=-Dkaraf.instances=%KARAF_HOME%/instances
+wrapper.java.additional.4=-Dkaraf.home=%KARAF_HOME%
+wrapper.java.additional.5=-Dkaraf.base=%KARAF_BASE%
+wrapper.java.additional.6=-Dkaraf.data=%KARAF_DATA%
+wrapper.java.additional.7=-Dkaraf.etc=%KARAF_ETC%
+wrapper.java.additional.8=-Dkaraf.restart.jvm.supported=true
+wrapper.java.additional.9=-Djava.io.tmpdir=%KARAF_DATA%/tmp
+wrapper.java.additional.10=-Djava.util.logging.config.file=%KARAF_BASE%/etc/java.util.logging.properties
+wrapper.java.additional.11=-Dcom.sun.management.jmxremote
+wrapper.java.additional.12=-Dkaraf.startLocalConsole=false
+wrapper.java.additional.13=-Dkaraf.startRemoteShell=true
# Uncomment to enable jmx
#wrapper.java.additional.n=-Dcom.sun.management.jmxremote.port=1616
diff --git
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
index 51a18772fb..b528acd0ae 100644
---
a/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
+++
b/wrapper/src/main/resources/org/apache/karaf/wrapper/internal/windows64/karaf-wrapper.conf
@@ -37,17 +37,19 @@ wrapper.java.library.path.1=%KARAF_BASE%/lib/wrapper/
# JVM Parameters
# note that n is the parameter number starting from 1.
-wrapper.java.additional.1=-Dkaraf.home="%KARAF_HOME%"
-wrapper.java.additional.2=-Dkaraf.base="%KARAF_BASE%"
-wrapper.java.additional.3=-Dkaraf.data="%KARAF_DATA%"
-wrapper.java.additional.4=-Dkaraf.etc="%KARAF_ETC%"
-wrapper.java.additional.5=-Dcom.sun.management.jmxremote
-wrapper.java.additional.6=-Dkaraf.startLocalConsole=false
-wrapper.java.additional.7=-Dkaraf.startRemoteShell=true
-wrapper.java.additional.8=-Djava.io.tmpdir="%KARAF_DATA%/tmp"
-# Uncomment if you need libraries on Java 8
-#wrapper.java.additional.9=-Djava.endorsed.dirs="%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed"
-#wrapper.java.additional.10=-Djava.ext.dirs="%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext"
+wrapper.java.additional.1=-Djava.endorsed.dirs=%JAVA_HOME%/jre/lib/endorsed;%JAVA_HOME%/lib/endorsed;%KARAF_HOME%/lib/endorsed
+wrapper.java.additional.2=-Djava.ext.dirs=%JAVA_HOME%/jre/lib/ext;%JAVA_HOME%/lib/ext;%KARAF_HOME%/lib/ext
+wrapper.java.additional.3=-Dkaraf.instances=%KARAF_HOME%/instances
+wrapper.java.additional.4=-Dkaraf.home=%KARAF_HOME%
+wrapper.java.additional.5=-Dkaraf.base=%KARAF_BASE%
+wrapper.java.additional.6=-Dkaraf.data=%KARAF_DATA%
+wrapper.java.additional.7=-Dkaraf.etc=%KARAF_ETC%
+wrapper.java.additional.8=-Dkaraf.restart.jvm.supported=true
+wrapper.java.additional.9=-Djava.io.tmpdir=%KARAF_DATA%/tmp
+wrapper.java.additional.10=-Djava.util.logging.config.file=%KARAF_BASE%/etc/java.util.logging.properties
+wrapper.java.additional.11=-Dcom.sun.management.jmxremote
+wrapper.java.additional.12=-Dkaraf.startLocalConsole=false
+wrapper.java.additional.13=-Dkaraf.startRemoteShell=true
# Uncomment to enable jmx
#wrapper.java.additional.n=-Dcom.sun.management.jmxremote.port=1616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Karaf specs activator is missing when used with wrapper
> -------------------------------------------------------
>
> Key: KARAF-5840
> URL: https://issues.apache.org/jira/browse/KARAF-5840
> Project: Karaf
> Issue Type: Bug
> Components: karaf-os-integration
> Affects Versions: 4.2.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 4.2.1
>
>
> Starting Karaf using the service wrapper (on Windows) shows missing Karaf
> Spec Activator:
> {code}
> Jul 12, 2018 11:00:27 AM org.apache.karaf.main.KarafActivatorManager
> startKarafActivators
> WARNING: Error starting karaf activator
> org.apache.karaf.specs.activator.Activator from url
> jar:file:/C:/apache-karaf/apache-karaf-4.2.0/lib/boot/org.apache.karaf.specs.activator-4.2.0.jar!/META-INF/MANIFEST.MF
> java.lang.NoClassDefFoundError: org/apache/karaf/specs/locator/OsgiLocator
> at
> org.apache.karaf.specs.activator.Activator.register(Activator.java:124)
> at
> org.apache.karaf.specs.activator.Activator.start(Activator.java:71)
> at
> org.apache.karaf.main.KarafActivatorManager.startKarafActivators(KarafActivatorManager.java:62)
> at org.apache.karaf.main.Main.launch(Main.java:280)
> at
> org.apache.karaf.wrapper.internal.service.Main.start(Main.java:55)
> at
> org.tanukisoftware.wrapper.WrapperManager$12.run(WrapperManager.java:2788)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.karaf.specs.locator.OsgiLocator
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at
> sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:349)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> ... 6 more
> {code}
> The Windows wrapper resource is probably outdated.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
