[
https://issues.apache.org/jira/browse/KARAF-5263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16712949#comment-16712949
]
ASF GitHub Bot commented on KARAF-5263:
---------------------------------------
jbonofre closed pull request #688: [KARAF-5263] Add naming for encryption and
shell:watch threads
URL: https://github.com/apache/karaf/pull/688
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/AutoEncryptionSupport.java
b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/AutoEncryptionSupport.java
index 662fc31c8c..9339f211ea 100644
---
a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/AutoEncryptionSupport.java
+++
b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/properties/AutoEncryptionSupport.java
@@ -34,6 +34,7 @@
import org.apache.felix.utils.properties.Properties;
import org.apache.karaf.jaas.modules.encryption.EncryptionSupport;
import org.apache.karaf.util.StreamUtils;
+import org.apache.karaf.util.ThreadUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -47,7 +48,7 @@
public AutoEncryptionSupport(Map<String, Object> properties) {
running = true;
encryptionSupport = new EncryptionSupport(properties);
- executor = Executors.newSingleThreadExecutor();
+ executor =
Executors.newSingleThreadExecutor(ThreadUtils.namedThreadFactory("encryption"));
executor.execute(this);
}
diff --git
a/shell/commands/src/main/java/org/apache/karaf/shell/commands/impl/WatchAction.java
b/shell/commands/src/main/java/org/apache/karaf/shell/commands/impl/WatchAction.java
index ddfc127a5f..1d6fe13911 100644
---
a/shell/commands/src/main/java/org/apache/karaf/shell/commands/impl/WatchAction.java
+++
b/shell/commands/src/main/java/org/apache/karaf/shell/commands/impl/WatchAction.java
@@ -48,6 +48,7 @@
import org.apache.karaf.shell.support.completers.CommandsCompleter;
import org.apache.karaf.shell.support.parsing.CommandLineImpl;
import org.apache.karaf.shell.support.parsing.DefaultParser;
+import org.apache.karaf.util.ThreadUtils;
import org.jline.terminal.Attributes;
import org.jline.terminal.Terminal;
import org.jline.utils.NonBlockingReader;
@@ -73,7 +74,7 @@
@Reference
SessionFactory sessionFactory;
- private ScheduledExecutorService executorService =
Executors.newSingleThreadScheduledExecutor();
+ private ScheduledExecutorService executorService =
Executors.newSingleThreadScheduledExecutor(ThreadUtils.namedThreadFactory("shell:watch"));
private boolean abort;
private Thread reading;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> org.apache.karaf.shell.cfg et al still reference obsolete 'karaf.admin.role'
> ----------------------------------------------------------------------------
>
> Key: KARAF-5263
> URL: https://issues.apache.org/jira/browse/KARAF-5263
> Project: Karaf
> Issue Type: Improvement
> Components: karaf
> Affects Versions: 4.0.9
> Reporter: Martin Lichtin
> Assignee: Jean-Baptiste Onofré
> Priority: Trivial
> Fix For: 4.2.2
>
>
> I believe karaf.admin.role is no longer supported:
> {noformat}
> #
> # Role name used for SSH access authorization
> # If not set, this defaults to the ${karaf.admin.role} configured in
> etc/system.properties
> #
> # sshRole = admin
> {noformat}
> Other occurences:
> * page https://karaf.apache.org/manual/latest/ the property name still occurs
> in 3 places.
> * JaasSecurityProvider.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
