[ 
https://issues.apache.org/jira/browse/KARAF-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755693#comment-16755693
 ] 

ASF subversion and git services commented on KARAF-6116:
--------------------------------------------------------

Commit 089f77e09e1f6e96135245748361e478203d85a0 in karaf's branch 
refs/heads/master from Mike Mansell
[ https://gitbox.apache.org/repos/asf?p=karaf.git;h=089f77e ]

[KARAF-6116] Adds support to karaf-maven-plugin add-to-repo for timestamped 
snapshots

Following the design in the Aether resolver library, the file name should use 
the artifact's version and not the base version. For timestamped snapshots (ie. 
0.1.0-20190111.021945-8), the base version resolves to (0.1.0-SNAPSHOT).
Without this change, normal Maven resolving (ie. within Karaf when using a mvn: 
URL), of a timestamped artifact won't work since it'll be looking for the wrong 
file name.


> karaf-maven-plugin adds incorrect snapshot version to repository
> ----------------------------------------------------------------
>
>                 Key: KARAF-6116
>                 URL: https://issues.apache.org/jira/browse/KARAF-6116
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf
>    Affects Versions: 4.2.2
>            Reporter: Mike Mansell
>            Priority: Major
>              Labels: maven
>             Fix For: 4.2.3
>
>
> When using the features-add-to-repository goal of the karaf-maven-plugin, and 
> it's resolving a feature that has an explicit snapshot version (ie. 
> 0.1.0-20190111.021945-8), it copies the SNAPSHOT version and not the explicit 
> version (ie. it copies 
> GROUPID/ARTIFACTID/0.1.0-SNAPSHOT/ARTIFACTID-0.1.0-SNAPSHOT.jar instead of 
> GROUPID/ARTIFACTID/0.1.0-SNAPSHOT/ARTIFACTID-0.1.0-20190111.021945-8.jar).
> This is because the MavenUtil.getFileName() uses artifact.getBaseVersion() 
> instead of artifact.getVersion().
> I believe this is a bug since looking at the 
> Dependency31Helper.pathFromAether() which effectively provides the same 
> functionality, it correctly uses the version and not base version.
> I understand that this goal is deprecated, but it is quite useful when 
> building just a Maven repo instead of the entire distribution (which can then 
> be easily layered into an existing Karaf Docker container), and it's a 
> one-line change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to