Nelson Antunes created KARAF-6418:
-------------------------------------

             Summary: Add flag to mark transitive dependencies with 
dependency="true"
                 Key: KARAF-6418
                 URL: https://issues.apache.org/jira/browse/KARAF-6418
             Project: Karaf
          Issue Type: New Feature
          Components: karaf
    Affects Versions: 4.2.6
            Reporter: Nelson Antunes


The karaf-maven-plugin doesn't allow to specify whether bundle is dependency or 
not solely via pom dependencies. Maintaining a manual feature file with all the 
current dependencies seems troublesome.

Adding a flag {{markTransitiveAsDependency}} indicating whether the plugin 
should mark transitive dependencies' bundle elements as a dependency would 
solve the problem. It should defaults to {{false}} to keep the current 
behaviour and also only have an effect when {{includeTransitiveDependency}} is 
{{true}}.

For consistency we should also add a {{markRuntimeScopeAsDependency}} flag, 
similarly indicating whether the plugin should also mark dependencies' with the 
_runtime_ scope, despite the fact that behaviour doesn't seem to be working 
([#KARAF-4537|https://issues.apache.org/jira/browse/KARAF-4537]).

 
----
{color:#505f79}Side notes:{color}

{color:#505f79}Isn't the {{DependencyHelper31}} effectively filtering-out 
dependencies with the scope "provided", rendering the {{ignoreScopeProvided}} 
flag useless? 
([Dependency31Helper.java#L231|https://github.com/pentaho/karaf/blob/master/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/utils/Dependency31Helper.java#L231)]{color}

{color:#505f79}Also, isn't it making the {{simplifyBundleDependencies}} flag 
useless, by always removing feature transitive dependencies regardless? 
([Dependency31Helper.java#L225|https://github.com/pentaho/karaf/blob/master/tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/utils/Dependency31Helper.java#L225)]{color}



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to