[ 
https://issues.apache.org/jira/browse/KARAF-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945150#comment-16945150
 ] 

Miroslav Beranič edited comment on KARAF-6447 at 10/5/19 8:32 PM:
------------------------------------------------------------------

Original stacktrace:

 
{code:java}
java.net.MalformedURLException: Unknown protocol: 
mvnjava.net.MalformedURLException: Unknown protocol: mvn at 
java.net.URL.<init>(URL.java:634) at java.net.URL.<init>(URL.java:497) at 
java.net.URL.<init>(URL.java:446) at 
org.apache.karaf.features.internal.service.FeatureConfigInstaller.installFeatureConfigs(FeatureConfigInstaller.java:106)
 at 
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installConfigs(BundleInstallSupportImpl.java:301)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installConfigs(FeaturesServiceImpl.java:1178)
 at 
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:953) 
at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1062)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:998)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl$$Lambda$83.00000000006C3F60.call(Unknown
 Source) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
at java.lang.Thread.run(Thread.java:819)Caused by: 
java.lang.IllegalStateException: Unknown protocol: mvn at 
org.apache.felix.framework.URLHandlersStreamHandlerProxy.parseURL(URLHandlersStreamHandlerProxy.java:373)
 at java.net.URL.<init>(URL.java:629) ... 13 moreorg.apache.karaf.features.core 
[org.apache.karaf.features.internal.service.BootFeaturesInstaller] ERROR : 
Error installing boot features{code}
 

After the update:

 

java.io.IOException: *mvn:bundle-name/0.1.1-SNAPSHOT/config/config-name*

java.io.IOException: *Failed to load config info from URL 
[mvn:bundle-name/0.1.1-SNAPSHOT/config/config-name] for feature 
[feature-name/0.1.1.SNAPSHOT].*

at 
org.apache.karaf.features.internal.service.FeatureConfigInstaller.installFeatureConfigs(FeatureConfigInstaller.java:109)
 at 
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installConfigs(BundleInstallSupportImpl.java:301)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installConfigs(FeaturesServiceImpl.java:1178)
 at 
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:953) 
at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1062)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:998)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl$$Lambda$83.00000000086CB8E0.call(Unknown
 Source) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
at java.lang.Thread.run(Thread.java:819)org.apache.karaf.features.core 
[org.apache.karaf.features.internal.service.BootFeaturesInstaller] ERROR : 
*Error installing boot featuresjava.io.IOException: 
mvn:bundle-name/0.1.1-SNAPSHOT/config/config-name] for feature 
[feature-name/0.1.1.SNAPSHOT] for feature [feature-name/0.1.1.SNAPSHOT]].*

at 
org.apache.karaf.features.internal.service.FeatureConfigInstaller.installFeatureConfigs(FeatureConfigInstaller.java:109)
 at 
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installConfigs(BundleInstallSupportImpl.java:301)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installConfigs(FeaturesServiceImpl.java:1178)
 at 
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:953) 
at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1062)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:998)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl$$Lambda$83.00000000086CB8E0.call(Unknown
 Source) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
at java.lang.Thread.run(Thread.java:819)

 

 


was (Author: mibesis):
Original stacktrace:

 
{code:java}
java.net.MalformedURLException: Unknown protocol: 
mvnjava.net.MalformedURLException: Unknown protocol: mvn at 
java.net.URL.<init>(URL.java:634) at java.net.URL.<init>(URL.java:497) at 
java.net.URL.<init>(URL.java:446) at 
org.apache.karaf.features.internal.service.FeatureConfigInstaller.installFeatureConfigs(FeatureConfigInstaller.java:106)
 at 
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installConfigs(BundleInstallSupportImpl.java:301)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installConfigs(FeaturesServiceImpl.java:1178)
 at 
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:953) 
at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1062)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:998)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl$$Lambda$83.00000000006C3F60.call(Unknown
 Source) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
at java.lang.Thread.run(Thread.java:819)Caused by: 
java.lang.IllegalStateException: Unknown protocol: mvn at 
org.apache.felix.framework.URLHandlersStreamHandlerProxy.parseURL(URLHandlersStreamHandlerProxy.java:373)
 at java.net.URL.<init>(URL.java:629) ... 13 moreorg.apache.karaf.features.core 
[org.apache.karaf.features.internal.service.BootFeaturesInstaller] ERROR : 
Error installing boot features{code}
 

After the update:

 

java.io.IOException: Failed to load config info from URL 
[mvn:org.apache.sling/org.apache.sling.karaf-configs/0.1.1-SNAPSHOT/config/org.apache.sling.jcr.repoinit.RepositoryInitializer-sling_scriptingjava.io.IOException:
 *Failed to load config info from URL 
[mvn:bundle-name/0.1.1-SNAPSHOT/config/config-name] for feature 
[feature-name/0.1.1.SNAPSHOT].* at 
org.apache.karaf.features.internal.service.FeatureConfigInstaller.installFeatureConfigs(FeatureConfigInstaller.java:109)
 at 
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installConfigs(BundleInstallSupportImpl.java:301)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installConfigs(FeaturesServiceImpl.java:1178)
 at 
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:953) 
at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1062)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:998)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl$$Lambda$83.00000000086CB8E0.call(Unknown
 Source) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
at java.lang.Thread.run(Thread.java:819)org.apache.karaf.features.core 
[org.apache.karaf.features.internal.service.BootFeaturesInstaller] ERROR : 
*Error installing boot featuresjava.io.IOException: 
mvn:bundle-name/0.1.1-SNAPSHOT/config/config-name] for feature 
[feature-name/0.1.1.SNAPSHOT] for feature [feature-name/0.1.1.SNAPSHOT]].*

at 
org.apache.karaf.features.internal.service.FeatureConfigInstaller.installFeatureConfigs(FeatureConfigInstaller.java:109)
 at 
org.apache.karaf.features.internal.service.BundleInstallSupportImpl.installConfigs(BundleInstallSupportImpl.java:301)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.installConfigs(FeaturesServiceImpl.java:1178)
 at 
org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:953) 
at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1062)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl.lambda$doProvisionInThread$13(FeaturesServiceImpl.java:998)
 at 
org.apache.karaf.features.internal.service.FeaturesServiceImpl$$Lambda$83.00000000086CB8E0.call(Unknown
 Source) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) 
at java.lang.Thread.run(Thread.java:819)

 

 

> Added more information to the thrown exception for malformed url.
> -----------------------------------------------------------------
>
>                 Key: KARAF-6447
>                 URL: https://issues.apache.org/jira/browse/KARAF-6447
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf
>    Affects Versions: 4.3.0
>            Reporter: Miroslav Beranič
>            Priority: Minor
>
> Feature Config Installer throws an exception when it does not recognize the 
> prefix, for example "mvn:".
>  
> With this change, stacktrace has more information to poinpoint what is the 
> problem.
>  
> Will create PR at the GitHub.
>  
> Changes made to the class 
> org.apache.karaf.features.internal.service.FeatureConfigInstaller located at:
> {code:java}
> karaf/features/core/src/main/java/org/apache/karaf/features/internal/service/FeatureConfigInstaller.java{code}
>  
> Changes ( at around line 102):
>  
> {code:java}
> if (config.isExternal()) {
>  try {
>  props.load(new URL(val));
>  } catch (java.net.MalformedURLException e) {
>  throw new IOException("Failed to load config info from URL [" + val + "] for 
> feature [" + feature.getName() + "/" + feature.getVersion() + "].");
>  }
>  } else {
>  props.load(new StringReader(val));
>  }{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to