[
https://issues.apache.org/jira/browse/KARAF-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174081#comment-17174081
]
ASF GitHub Bot commented on KARAF-6797:
---------------------------------------
jbonofre commented on a change in pull request #1142:
URL: https://github.com/apache/karaf/pull/1142#discussion_r467694902
##########
File path:
jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java
##########
@@ -35,14 +35,14 @@
@Service
public class ManageRealmCommand extends JaasCommandSupport {
- @Option(name = "--realm", description = "JAAS Realm", required = false,
multiValued = false)
+ @Option(name = "--realm", description = "JAAS Realm. Must be combined with
--module", required = false, multiValued = false)
@Completion(RealmCompleter.class)
String realmName;
@Option(name = "--index", description = "Realm Index", required = false,
multiValued = false)
Review comment:
I would add the "must be combined" statement here and leave realm option
description as it is.
##########
File path:
jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java
##########
@@ -35,14 +35,14 @@
@Service
public class ManageRealmCommand extends JaasCommandSupport {
- @Option(name = "--realm", description = "JAAS Realm", required = false,
multiValued = false)
+ @Option(name = "--realm", description = "JAAS Realm. Must be combined with
--module", required = false, multiValued = false)
Review comment:
That's not fully correct. Realm can be combined with module, but also
with index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> JAAS realm-manage with module name failed
> -----------------------------------------
>
> Key: KARAF-6797
> URL: https://issues.apache.org/jira/browse/KARAF-6797
> Project: Karaf
> Issue Type: Bug
> Components: karaf
> Affects Versions: 4.2.8
> Environment: Mac OS Catalina
> OpenJDK 11
> Reporter: Andre Schlegel-Tylla
> Assignee: Jean-Baptiste Onofré
> Priority: Major
>
>
> If I try to manage a realm via "--module MODULE-CLASS-NAME" I got the message
> "A valid realm or the realm index need to be specified".
> If I'm using the index I have no problems.
> {code:java}
> virtimo@bpc()> jaas:realm-list
> Index │ Realm Name │ Login Module Class Name
> ──────┼────────────┼─────────────────────────────────────────────────────────────────
> 1 │ inubit │ de.virtimo.bpc.core.auth.jaas.inubit.InubitLoginModule
> 2 │ jdbc │ de.virtimo.bpc.core.auth.jaas.jdbc.JDBCLoginModule
> 3 │ karaf │
> org.apache.karaf.jaas.modules.properties.PropertiesLoginModule
> 4 │ karaf │
> org.apache.karaf.jaas.modules.publickey.PublickeyLoginModule
> 5 │ karaf │ org.apache.karaf.jaas.modules.audit.FileAuditLoginModule
> 6 │ karaf │ org.apache.karaf.jaas.modules.audit.LogAuditLoginModule
> 7 │ karaf │
> org.apache.karaf.jaas.modules.audit.EventAdminAuditLoginModule
> 8 │ keycloak │
> de.virtimo.bpc.core.auth.jaas.keycloak.DirectKeycloakLoginModule
> virtimo@bpc()> jaas:realm-manage --module
> org.apache.karaf.jaas.modules.properties.PropertiesLoginModule
> A valid realm or the realm index need to be specified
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
