[
https://issues.apache.org/jira/browse/KARAF-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226076#comment-17226076
]
ASF GitHub Bot commented on KARAF-6897:
---------------------------------------
paulojramos commented on a change in pull request #1246:
URL: https://github.com/apache/karaf/pull/1246#discussion_r517383381
##########
File path:
tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/KarMojo.java
##########
@@ -209,6 +210,13 @@ private File resolveFile(String file) {
resources.add(resourceToArtifact(bundle.getLocation(),
false));
}
}
+ for (Conditional conditional : feature.getConditional()) {
+ for (BundleInfo bundle : conditional.getBundles()) {
+ if (ignoreDependencyFlag || (!ignoreDependencyFlag &&
!bundle.isDependency())) {
Review comment:
I have simplified the conditions.
Wouldn't really be comfortable adding integration tests, being this my first
contribution to the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> .kar generated by karaf-maven-plugin does not contain conditional bundles (no
> offline support)
> ----------------------------------------------------------------------------------------------
>
> Key: KARAF-6897
> URL: https://issues.apache.org/jira/browse/KARAF-6897
> Project: Karaf
> Issue Type: Bug
> Components: karaf
> Affects Versions: 4.3.0, 4.2.10
> Reporter: Paulo Ramos
> Priority: Major
> Fix For: 4.3.1
>
>
> It appears that KARAF-4082 fixed this for the features-add-to-repository goal.
> Issue persists for the kar goal. Bundles under a conditional tag are not
> included in the kar repository.
> The behavior can be replicated with any feature that declares conditional
> bundles.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
