[ 
https://issues.apache.org/jira/browse/KARAF-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258247#comment-17258247
 ] 

ASF GitHub Bot commented on KARAF-6983:
---------------------------------------

paulsp commented on pull request #221:
URL: https://github.com/apache/karaf-decanter/pull/221#issuecomment-754017357


   JB,  I found this configuration property in the source code while 
configuring Alerting rules and noticed the rules were not catching events.  The 
events originated from decanter-collector-oshi and the field names contains one 
or more dots. I was using decanter-appender-file with JSON formatting to 
identify the field names, which resulted in using the wrong field name.  Only 
after digging into the source code did I find the property. 
   
   The option to replace the dot with an underscore was added in v2.1.0 by 
[KARAF-5793] and that was to accommodate changes to ElasticSearch. The title of 
the issue includes the phrase "Provide an option replace", but nowhere outside 
of the issue is the property documented.
   
   The point of this PR is to make the property visible within the 
configuration files, even if 99% of the user base never changed the property 
value.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> JSON Marshaller configuration property "replaceDotsByUnderscores" not in .cfg
> -----------------------------------------------------------------------------
>
>                 Key: KARAF-6983
>                 URL: https://issues.apache.org/jira/browse/KARAF-6983
>             Project: Karaf
>          Issue Type: Improvement
>          Components: decanter
>            Reporter: Paul Spencer
>            Priority: Minor
>
> The configuration property "replaceDotsByUnderscores" was added by KARAF-5793 
> to the code, but is not in the configuration file.  The improvement is to add 
> the property and the configuration file for the Marshaller.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to