[ 
https://issues.apache.org/jira/browse/KARAF-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342993#comment-17342993
 ] 

Jean-Baptiste Onofré commented on KARAF-7150:
---------------------------------------------

It sounds reasonable to me, yes. Thanks for the report.

> Hazelcast TcpIPConfig is not reloaded on changes to hazelcast.xml 
> ------------------------------------------------------------------
>
>                 Key: KARAF-7150
>                 URL: https://issues.apache.org/jira/browse/KARAF-7150
>             Project: Karaf
>          Issue Type: Bug
>    Affects Versions: 4.3.1
>            Reporter: Abhayjit Kharbanda
>            Assignee: Jean-Baptiste Onofré
>            Priority: Critical
>
> While using kubernetes-discovery with cellar I came across this issue . The 
> default etc/hazelcast.xml has tcp-ip disabled and multicast enabled. 
> In this scenario , when kubernetes-discovery runs and discovers members , 
> adding them to tcpConfig throws an NPE 
> {noformat}
> java.lang.NullPointerException: null                                          
>                                                                               
>                                                          at 
> org.apache.karaf.cellar.hazelcast.factory.HazelcastConfigurationManager.isUpdated(HazelcastConfigurationManager.java:89)
>  ~[!/:?]                                                            at 
> org.apache.karaf.cellar.hazelcast.factory.HazelcastServiceFactory.update(HazelcastServiceFactory.java:52)
>  ~[!/:?]                                                                      
>      at 
> org.apache.karaf.cellar.hazelcast.internal.osgi.Activator.updated(Activator.java:433)
>  [!/:?]                                                                       
>                                at 
> org.apache.karaf.cellar.hazelcast.internal.osgi.Activator.updated(Activator.java:424)
>  [!/:?]                                                                       
>                                        at 
> org.apache.felix.cm.impl.helper.ManagedServiceTracker.updated(ManagedServiceTracker.java:189)
>  [!/:?]                                                                       
>                                at 
> org.apache.felix.cm.impl.helper.ManagedServiceTracker.updateService(ManagedServiceTracker.java:152)
>  [!/:?]                                                                       
>                          at 
> org.apache.felix.cm.impl.helper.ManagedServiceTracker.provideConfiguration(ManagedServiceTracker.java:85)
>  [!/:?]                                                                       
>                    at 
> org.apache.felix.cm.impl.ConfigurationManager$UpdateConfiguration.run(ConfigurationManager.java:1409)
>  [!/:?]                                                                       
>                  at 
> org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:122) [!/:?]      
>                                                                               
>                                               at 
> org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:84) [!/:?]        
>                                                                               
>                                               at java.lang.Thread.run(Unknown 
> Source) [?:?]                  
> {noformat}
> I updated the etc/hazelcast.xml to enable tcp-ip and expected this error to 
> go away but I still continued to get the above NPE since TcpIpConfig wasnt 
> updated . 
> I had to manually restart hazelcast bundle to fix the above error post the 
> hazelcast.xml changes.
> Can we look at triggering the update of TcpIpConfig in case of changes and 
> also if possible update this config automatically when cellar-kubernetes 
> feature is installed to avoid having to update the etc/hazelcast.xml manually



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to