[ 
https://issues.apache.org/jira/browse/KARAF-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17457066#comment-17457066
 ] 

ASF GitHub Bot commented on KARAF-7282:
---------------------------------------

wborn commented on pull request #1457:
URL: https://github.com/apache/karaf/pull/1457#issuecomment-990869988


   I gave Karaf 4.3.4 a test and now see bundles being refreshed which weren't 
when installing the same features with Karaf 4.3.3. Is this expected behaviour 
@jbonofre ? The `autoRefresh` config is commented in our 
`org.apache.karaf.features.cfg` file so I guess we use the default. Maybe we 
need to explicitly set it to `false` in Karaf 4.3.4?
   
   ## Karaf 4.3.3
   
   ```
   openhab> feature:install -t -v openhab-voice-googletts                       
                                                                                
                                                
   Adding features: openhab-voice-googletts/[3.2.0.SNAPSHOT,3.2.0.SNAPSHOT]
   Changes to perform:
     Region: root
       Bundles to install:
         
mvn:org.openhab.addons.bundles/org.openhab.voice.googletts/3.2.0-SNAPSHOT
   ```
   
   ## Karaf 4.3.4
   
   ```
   openhab> feature:install -t -v openhab-voice-googletts
   Adding features: openhab-voice-googletts/[3.2.0.SNAPSHOT,3.2.0.SNAPSHOT]
   Changes to perform:
     Region: root
       Bundles to install:
         
mvn:org.openhab.addons.bundles/org.openhab.voice.googletts/3.2.0-SNAPSHOT
     Bundles to refresh:
       org.apache.aries.jax.rs.whiteboard/2.0.1 (Wired to 
org.apache.cxf.cxf-core/3.4.5 which is being refreshed)
       org.apache.cxf.cxf-core/3.4.5 (Wired to 
org.apache.servicemix.bundles.saaj-impl/1.4.0.2 which is being refreshed)
       org.apache.cxf.cxf-rt-frontend-jaxrs/3.4.5 (Wired to 
org.apache.cxf.cxf-core/3.4.5 which is being refreshed)
       org.apache.cxf.cxf-rt-rs-client/3.4.5 (Wired to 
org.apache.cxf.cxf-core/3.4.5 which is being refreshed)
       org.apache.cxf.cxf-rt-rs-sse/3.4.5 (Wired to 
org.apache.cxf.cxf-core/3.4.5 which is being refreshed)
       org.apache.cxf.cxf-rt-security/3.4.5 (Wired to 
org.apache.cxf.cxf-core/3.4.5 which is being refreshed)
       org.apache.cxf.cxf-rt-transports-http/3.4.5 (Wired to 
org.apache.cxf.cxf-core/3.4.5 which is being refreshed)
       org.apache.servicemix.bundles.saaj-impl/1.4.0.2 (Should be wired to: 
org.jvnet.staxex.stax-ex/1.7.4 (through 
[org.apache.servicemix.bundles.saaj-impl/1.4.0.2] osgi.wiring.package; 
filter:="(&(osgi.wiring.package=org.jvnet.staxex)(version>=1.7.0)(!(version>=2.0.0)))"))
       org.openhab.core.automation.rest/3.2.0.202112101019 (Wired to 
org.apache.aries.jax.rs.whiteboard/2.0.1 which is being refreshed)
       org.openhab.core.id/3.2.0.202112101018 (Wired to 
org.apache.aries.jax.rs.whiteboard/2.0.1 which is being refreshed)
       org.openhab.core.io.rest/3.2.0.202112101018 (Wired to 
org.apache.aries.jax.rs.whiteboard/2.0.1 which is being refreshed)
       org.openhab.core.io.rest.audio/3.2.0.202112101018 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.io.rest.auth/3.2.0.202112101018 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.io.rest.core/3.2.0.202112101019 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.io.rest.sitemap/3.2.0.202112101019 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.io.rest.sse/3.2.0.202112101018 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.io.rest.swagger/3.2.0.202112101018 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.io.rest.ui/3.2.0.202112101019 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.io.rest.voice/3.2.0.202112101018 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.core.ui.icon/3.2.0.202112101019 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.ui.basic/3.2.0.202112092106 (Wired to 
org.openhab.core.io.rest.sitemap/3.2.0.202112101019 which is being refreshed)
       org.openhab.ui.habpanel/3.2.0.202112092106 (Wired to 
org.openhab.core.io.rest/3.2.0.202112101018 which is being refreshed)
       org.openhab.ui.iconset.classic/3.2.0.202112092106 (Wired to 
org.openhab.core.ui.icon/3.2.0.202112101019 which is being refreshed)
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> global autoRefresh logic does not work as expected
> --------------------------------------------------
>
>                 Key: KARAF-7282
>                 URL: https://issues.apache.org/jira/browse/KARAF-7282
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf
>    Affects Versions: 4.3.3
>            Reporter: Stefan Wachter
>            Assignee: Jean-Baptiste Onofré
>            Priority: Minor
>             Fix For: 4.4.0, 4.3.4, 4.2.13
>
>
> In KARAF-6953 a new global configuration setting {{autoRefresh}} was added. 
> When that property is set to {{false}} then in the {{Deployer.deploy}} method 
> the logic is reversed, i.e. auto refreshing takes place.
> This happens by the code:
> {code:java}
>  if (!request.autoRefresh) {
>     noRefreshUnmanaged = request.autoRefresh;
>     noRefreshManaged = request.autoRefresh;
>     noRefresh = request.autoRefresh;
> }
> {code}
> The result is that all {{noRefresh...}} variables are set to {{false}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to