[
https://issues.apache.org/jira/browse/KARAF-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583442#comment-17583442
]
ASF GitHub Bot commented on KARAF-7538:
---------------------------------------
vladimirfx opened a new pull request, #1609:
URL: https://github.com/apache/karaf/pull/1609
This is not breaking change because previvous implementation can not work as
intended.
> Assembly Mojo parameter translatedUrls is unusable
> --------------------------------------------------
>
> Key: KARAF-7538
> URL: https://issues.apache.org/jira/browse/KARAF-7538
> Project: Karaf
> Issue Type: Bug
> Components: karaf
> Affects Versions: 4.4.1
> Reporter: Vladimir Konkov
> Priority: Major
>
> Parameter {{translatedUrls}} of type Map<String, String> should contain URL
> as key wich can not be expressed by current Maven Map parameter conversion
> logic:
> [https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#maps]
>
> Map parameters requires to use XML element name as map key. XML element name
> can't be URL by XML spec.
> So no even theoretical way to use translatedUrls, because key must URL (for
> Karaf) but key is XML element name (in Maven) and can't be URL by XML spec.
> I suggest to change {{translatedUrls}} type to Properties. Example config:
> {code:java}
> <translatedUrls>
> <property>
> <name>jar:mvn:some.group/bundle-artefact/1.0.1!/features.xml</name>
>
> <value>file:${project.build.directory}/bundle-artefact/features.xml</value>
> </property>
> </translatedUrls>
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
