[ 
https://issues.apache.org/jira/browse/KARAF-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617892#comment-17617892
 ] 

ASF GitHub Bot commented on KARAF-7068:
---------------------------------------

awrb commented on code in PR #1626:
URL: https://github.com/apache/karaf/pull/1626#discussion_r995991814


##########
assemblies/features/standard/src/main/feature/feature.xml:
##########
@@ -630,6 +630,7 @@ update = manager
     </feature>
 
     <feature name="instance" description="Provide Instance support" 
version="${project.version}">
+        <bundle 
dependency="true">mvn:org.apache.commons/commons-compress/${commons-compress.version}</bundle>

Review Comment:
   I removed `commons-compress` dependency and just left the zip option. Sadly 
maintaining file permissions (e.g. 0755 in bin/karaf) does not seem to work. 
Seems to be a bug/limitation in JDK:
   https://bugs.openjdk.org/browse/JDK-6194856
   https://stackoverflow.com/questions/10699334/change-permission-of-a-zipentry
   





> Add instance:package command
> ----------------------------
>
>                 Key: KARAF-7068
>                 URL: https://issues.apache.org/jira/browse/KARAF-7068
>             Project: Karaf
>          Issue Type: New Feature
>          Components: karaf
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>
> {{instance:package}} should create a tar.gz/zip for a given instance.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to