[
https://issues.apache.org/jira/browse/KARAF-6697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628561#comment-17628561
]
ASF GitHub Bot commented on KARAF-6697:
---------------------------------------
wborn commented on code in PR #1678:
URL: https://github.com/apache/karaf/pull/1678#discussion_r1013474904
##########
tooling/karaf-maven-plugin/src/main/java/org/apache/karaf/tooling/VerifyMojo.java:
##########
@@ -48,8 +48,6 @@
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.atomic.AtomicLong;
import java.util.function.BiFunction;
-import java.util.function.Function;
-import java.util.function.Supplier;
Review Comment:
These are unused imports.
> karaf-maven-plugin verify goal leaks threads
> --------------------------------------------
>
> Key: KARAF-6697
> URL: https://issues.apache.org/jira/browse/KARAF-6697
> Project: Karaf
> Issue Type: Bug
> Components: karaf
> Affects Versions: 4.2.7, 4.2.8
> Reporter: Wouter Born
> Priority: Major
> Attachments: karaf-no-threads-leak.png, karaf-threads-leak.png
>
>
> We use the verify goal of the karaf-maven-plugin to verify 200+ features in
> our openHAB add-ons build (see
> [pom.xml|https://github.com/openhab/openhab-addons/blob/2.5.x/bundles/pom.xml]).
> When monitoring the build using [VisualVM|https://visualvm.github.io/] the
> live thread counts keep increasing each time the verify goal is executed.
> It increases to ~2000 threads after invoking the goal 200+ times:
>
> !karaf-threads-leak.png!
>
> When the
> [plugin|https://github.com/openhab/openhab-addons/blob/65eff40dba68a346845f4c69db495bed2086b05f/bundles/pom.xml#L399-L402]
> is removed from the build everything returns to normal (this was a full
> build with tests):
>
> !karaf-no-threads-leak.png!
>
> To reproduce it on our code:
> # {{git clone -b 2.5.x --single-branch
> [email protected]:openhab/openhab-addons.git}}
> # {{cd openhab-addons}}
> # {{mvn clean install -DskipChecks -DskipTests}}
> # Monitor the live thread counts using a tool like VisualVM
> When re-running the same build without Karaf feature validation, VisualVM
> will show that the live thread counts peak at 20 instead:
> # {{mvn clean install -DskipChecks -DskipTests -Dfeatures.verify.skip=true}}
> I also tested the 4.2.8 version of the plugin but it was still leaking
> threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
