[ 
https://issues.apache.org/jira/browse/KARAF-7677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701305#comment-17701305
 ] 

ASF GitHub Bot commented on KARAF-7677:
---------------------------------------

wborn commented on code in PR #1715:
URL: https://github.com/apache/karaf/pull/1715#discussion_r1139063272


##########
features/core/src/main/java/org/apache/karaf/features/internal/service/StaticInstallSupport.java:
##########
@@ -45,7 +45,7 @@ public void refreshPackages(Collection<Bundle> bundles) 
throws InterruptedExcept
 
     @Override
     public void updateBundle(Bundle bundle, String uri, InputStream is) throws 
BundleException {
-        System.err.println("Update bundle is not supported in the static 
installer");
+        System.err.printf("Update bundle is not supported in the static 
installer: bundle %s, uri %s\n", bundle == null ? "null" : 
bundle.getSymbolicName(), uri);

Review Comment:
   ```suggestion
           System.err.printf("Update bundle is not supported in the static 
installer: bundle %s, uri %s%n", bundle == null ? "null" : 
bundle.getSymbolicName(), uri);
   ```
   
   This seems to be an issue in other places in the code base as well.





> Log the offending bundle if a bundle refresh occurs during assembly
> -------------------------------------------------------------------
>
>                 Key: KARAF-7677
>                 URL: https://issues.apache.org/jira/browse/KARAF-7677
>             Project: Karaf
>          Issue Type: Improvement
>          Components: karaf
>    Affects Versions: 4.4.3
>            Reporter: Ciprian Ciubotariu
>            Priority: Trivial
>
> The karaf assembly plugin will fail if the assembled features/bundles cause a 
> refresh. This can happen quite often when developing complex assemblies. 
> However, the error text is not descriptive enough to help in tracking the 
> source of the problem.
> I think this trivial change, that shows the offending bundle in the build 
> log, will be of great help in such situations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to