[jira] [Commented] (KARAF-5014) First role of group definition in users.properties missing

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/KARAF-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948654#comment-17948654
 ] 

ASF GitHub Bot commented on KARAF-5014:
---------------------------------------

stataru8 commented on code in PR #1863:
URL: https://github.com/apache/karaf/pull/1863#discussion_r2070201105


##########
jaas/command/src/main/java/org/apache/karaf/jaas/command/ListUsersCommand.java:
##########
@@ -104,6 +105,8 @@ private List<String> displayGroupRoles(BackingEngine 
engine, String userName, Gr
                 names.add(roleName);
                 table.addRow().addContent(userName, group.getName(), roleName);
             }
+        } else {
+            table.addRow().addContent(userName, group.getName(), "");

Review Comment:
   I don't know if this proposal makes sense. I can revert.
   
   **Setup: user `foo` without any groups or roles declared.**
   
   Current behaviour
   ```
   karaf@trun()> jaas:group-add foo g1
   karaf@trun()> jaas:update
   karaf@trun()> jaas:realm-manage --realm karaf --module 
org.apache.karaf.jaas.modules.properties.PropertiesLoginModule
   karaf@trun()> jaas:user-list
   User Name │ Group      │ Role
   ──────────┼────────────┼──────────────
   foo       │            │
   ```
   
   Proposal
   ```
   karaf@trun()> jaas:group-add foo g1
   karaf@trun()> jaas:update
   karaf@trun()> jaas:realm-manage --realm karaf --module 
org.apache.karaf.jaas.modules.properties.PropertiesLoginModule
   karaf@trun()> jaas:user-list
   User Name │ Group      │ Role
   ──────────┼────────────┼──────────────
   foo       │ g1         │
   ```
   
   Proposal - more tests
   ```
   karaf@trun()> jaas:role-add foo r1
   karaf@trun()> jaas:update
   karaf@trun()> jaas:realm-manage --realm karaf --module 
org.apache.karaf.jaas.modules.properties.PropertiesLoginModule
   karaf@trun()> jaas:user-list
   User Name │ Group      │ Role
   ──────────┼────────────┼──────────────
   foo       │ g1         │
   foo       │            │ r1
   karaf@trun()> jaas:group-role-add g1 r1
   karaf@trun()> jaas:update
   karaf@trun()> jaas:realm-manage --realm karaf --module 
org.apache.karaf.jaas.modules.properties.PropertiesLoginModule
   karaf@trun()> jaas:user-list
   User Name │ Group      │ Role
   ──────────┼────────────┼──────────────
   foo       │ g1         │ r1
   ```
   





> First role of group definition in users.properties missing 
> -----------------------------------------------------------
>
>                 Key: KARAF-5014
>                 URL: https://issues.apache.org/jira/browse/KARAF-5014
>             Project: Karaf
>          Issue Type: Bug
>          Components: karaf
>    Affects Versions: 4.0.4
>            Reporter: Andre Schlegel-Tylla
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>
> The first role of an group got lost in role list:
> {code}
> bpcadmin = {CRYPT}...{CRYPT},bpcadmin,_g_\:zauberer,_g_\:masterdata
> _g_\:masterdata = VAM-administrator,VAM_organization_12001,wosinddieweiteren
> _g_\:zauberer=erstefehlt,abracadabra,simsalabim,sesamoeffnedich,hexhex
> {code}
> The roles "VAM-administrator" and "erstefehlt" are not listet on user 
> "bpcadmin".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)