turbaszek commented on a change in pull request #91: URL: https://github.com/apache/kibble/pull/91#discussion_r523422522
########## File path: kibble/__main__.py ########## @@ -15,9 +15,91 @@ # specific language governing permissions and limitations # under the License. +import click +from getpass import getpass + +from kibble.cli import setup_command +from kibble.version import version as kv + +from kibble.configuration import conf + + +def get_user_input(msg: str, secure: bool = False): + value = None + while not value: + value = getpass(msg) if secure else input(msg) + return value + + [email protected]() +def cli(): + """A simple command line tool for kibble""" + + [email protected]("version", short_help="displays the current kibble version") +def version(): + click.echo(kv) + + [email protected]("setup", short_help="starts the setup process for kibble") [email protected]( + "-u", + "--uri", + default=conf.get("elasticsearch", "conn_uri"), + help="Pre-defined connection uri for ElasticSearch.", Review comment: ```suggestion help="connection uri for ElasticSearch.", ``` Let's remove this "pre-defined", in my opinion it looks weird in the `kibble setup --help` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
